Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(957)

Unified Diff: build/android/adb_command_line_functions.sh

Issue 1469143002: Refactor adb_*_command_line helpers bash->python (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review nits Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/adb_command_line.py ('k') | build/android/adb_content_shell_command_line » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/adb_command_line_functions.sh
diff --git a/build/android/adb_command_line_functions.sh b/build/android/adb_command_line_functions.sh
deleted file mode 100755
index 7ea98b09be67f9a163ed459fda5b12b53241cc48..0000000000000000000000000000000000000000
--- a/build/android/adb_command_line_functions.sh
+++ /dev/null
@@ -1,40 +0,0 @@
-#!/bin/bash
-#
-# Copyright 2015 The Chromium Authors. All rights reserved.
-# Use of this source code is governed by a BSD-style license that can be
-# found in the LICENSE file.
-
-# Variables must be set before calling:
-# CMD_LINE_FILE - Path on device to flags file.
-# REQUIRES_SU - Set to 1 if path requires root.
-function set_command_line() {
- SU_CMD=""
- if [[ "$REQUIRES_SU" = 1 ]]; then
- # Older androids accept "su -c", while newer use "su uid".
- SDK_LEVEL=$(adb shell getprop ro.build.version.sdk | tr -d '\r')
- # E.g. if no device connected.
- if [[ -z "$SDK_LEVEL" ]]; then
- exit 1
- fi
- SU_CMD="su -c"
- if (( $SDK_LEVEL >= 21 )); then
- SU_CMD="su 0"
- fi
- fi
-
- if [ $# -eq 0 ] ; then
- # If nothing specified, print the command line (stripping off "chrome ")
- adb shell "cat $CMD_LINE_FILE 2>/dev/null" | cut -d ' ' -s -f2-
- elif [ $# -eq 1 ] && [ "$1" = '' ] ; then
- # If given an empty string, delete the command line.
- set -x
- adb shell $SU_CMD rm $CMD_LINE_FILE >/dev/null
- else
- # Else set it.
- set -x
- adb shell "echo 'chrome $*' | $SU_CMD dd of=$CMD_LINE_FILE"
- # Prevent other apps from modifying flags (this can create security issues).
- adb shell $SU_CMD chmod 0664 $CMD_LINE_FILE
- fi
-}
-
« no previous file with comments | « build/android/adb_command_line.py ('k') | build/android/adb_content_shell_command_line » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698