Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 146833011: A64: Don't use a 'debug' instruction to implement the 'trace_sim' option. (Closed)

Created:
6 years, 11 months ago by Alexandre Rames
Modified:
6 years, 11 months ago
Reviewers:
m.m.capewell
CC:
v8-dev
Visibility:
Public.

Description

A64: Don't use a 'debug' instruction to implement the 'trace_sim' option. Instead let the 'trace_sim' flag override normal tracing settings. R=m.m.capewell@googlemail.com Committed: https://code.google.com/p/v8/source/detail?r=18857

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -13 lines) Patch
M src/a64/code-stubs-a64.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/a64/simulator-a64.cc View 2 chunks +9 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Alexandre Rames
6 years, 11 months ago (2014-01-27 11:25:54 UTC) #1
m.m.capewell
lgtm
6 years, 11 months ago (2014-01-27 14:04:14 UTC) #2
Alexandre Rames
6 years, 11 months ago (2014-01-27 15:26:55 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r18857 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698