Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1326)

Unified Diff: src/a64/code-stubs-a64.cc

Issue 146833011: A64: Don't use a 'debug' instruction to implement the 'trace_sim' option. (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental/a64
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/a64/simulator-a64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/a64/code-stubs-a64.cc
diff --git a/src/a64/code-stubs-a64.cc b/src/a64/code-stubs-a64.cc
index 8a62bf3e97ca3b48f26706c3a99e202c6ad9da94..d444fa4700d23767c21482b7cd053a3e16bd5e69 100644
--- a/src/a64/code-stubs-a64.cc
+++ b/src/a64/code-stubs-a64.cc
@@ -2909,12 +2909,6 @@ void JSEntryStub::GenerateBody(MacroAssembler* masm, bool is_construct) {
ASSERT(jssp.Is(__ StackPointer()));
Register code_entry = x0;
- // TODO(all): We shouldn't emit debug instructions unconditionally since they
- // will not work outside the simulator. We need to rethink how these commands
- // interact with --trace-sim. For now, though, this turns on instruction
- // tracing _if_ --trace-sim is specified.
- __ Debug("TRACE ENTRY", 0, TRACE_ENABLE | LOG_ALL);
-
// Enable instruction instrumentation. This only works on the simulator, and
// will have no effect on the model or real hardware.
__ EnableInstrumentation();
« no previous file with comments | « no previous file | src/a64/simulator-a64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698