chrome/browser/ui/passwords/passwords_model_delegate.h - Issue 1467993002: Remove ManagePasswordsUIController::NavigateToSmartLockPage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/passwords/passwords_model_delegate.h

Issue 1467993002: Remove ManagePasswordsUIController::NavigateToSmartLockPage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Switching infobars to non-localised link, moving kPasswordManagerAccountDashboardURL to components Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/passwords/manage_passwords_ui_controller.cc ('k') | chrome/browser/ui/webui/options/password_manager_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/passwords/passwords_model_delegate.h

diff --git a/chrome/browser/ui/passwords/passwords_model_delegate.h b/chrome/browser/ui/passwords/passwords_model_delegate.h

index c104c19730cd290261ee7602776bad88947fab26..522622516fdd4daac61e3a1bd89c4e22e6f76fe3 100644

--- a/chrome/browser/ui/passwords/passwords_model_delegate.h

+++ b/chrome/browser/ui/passwords/passwords_model_delegate.h

@@ -80,10 +80,8 @@ class PasswordsModelDelegate {

const autofill::PasswordForm& form,

password_manager::CredentialType credential_type) = 0;

- // Two different ways to open a new tab pointing to passwords.google.com.

- // TODO(crbug.com/548259) eliminate one of them.

+ // Open a new tab pointing to passwords.google.com.

virtual void NavigateToExternalPasswordManager() = 0;

- virtual void NavigateToSmartLockPage() = 0;

// Open a new tab, pointing to the Smart Lock help article.

virtual void NavigateToSmartLockHelpPage() = 0;

// Open a new tab, pointing to the password manager settings page.