chrome/browser/ui/webui/options/password_manager_handler.cc - Issue 1467993002: Remove ManagePasswordsUIController::NavigateToSmartLockPage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/password_manager_handler.cc

Issue 1467993002: Remove ManagePasswordsUIController::NavigateToSmartLockPage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Switching infobars to non-localised link, moving kPasswordManagerAccountDashboardURL to components Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/webui/options/password_manager_handler.cc

diff --git a/chrome/browser/ui/webui/options/password_manager_handler.cc b/chrome/browser/ui/webui/options/password_manager_handler.cc

index 23055dd35eeddb5eec9dda2d8e2eb1ca178feb93..7523e5cc988123bf4cc07b82f10a4d32334f926f 100644

--- a/chrome/browser/ui/webui/options/password_manager_handler.cc

+++ b/chrome/browser/ui/webui/options/password_manager_handler.cc

@@ -20,6 +20,7 @@

#include "components/autofill/core/common/password_form.h"

#include "components/browser_sync/browser/profile_sync_service.h"

#include "components/password_manager/core/browser/password_bubble_experiment.h"

+#include "components/password_manager/core/browser/password_manager_constants.h"

#include "components/password_manager/core/browser/password_ui_utils.h"

#include "components/password_manager/core/common/experiments.h"

#include "components/url_formatter/url_formatter.h"

@@ -111,11 +112,12 @@ void PasswordManagerHandler::GetLocalizedValues(

localized_strings->SetString("passwordManagerLearnMoreURL",

chrome::kPasswordManagerLearnMoreURL);

- localized_strings->SetString("passwordsManagePasswordsLink",

- chrome::kPasswordManagerAccountDashboardURL);

+ localized_strings->SetString(

+ "passwordsManagePasswordsLink",

+ password_manager::kPasswordManagerAccountDashboardURL);

std::string management_hostname =

- GURL(chrome::kPasswordManagerAccountDashboardURL).host();

+ GURL(password_manager::kPasswordManagerAccountDashboardURL).host();

base::string16 link_text = base::UTF8ToUTF16(management_hostname);

size_t offset;

base::string16 full_text = l10n_util::GetStringFUTF16(

« no previous file with comments | « chrome/browser/ui/passwords/passwords_model_delegate.h ('k') | chrome/common/url_constants.h » ('j') | no next file with comments »