chrome/browser/ui/passwords/manage_passwords_ui_controller.cc - Issue 1467993002: Remove ManagePasswordsUIController::NavigateToSmartLockPage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

Issue 1467993002: Remove ManagePasswordsUIController::NavigateToSmartLockPage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Switching infobars to non-localised link, moving kPasswordManagerAccountDashboardURL to components Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/passwords/manage_passwords_ui_controller.h ('k') | chrome/browser/ui/passwords/passwords_model_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

diff --git a/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc b/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

index e348ec0a059b2785079defc875271fc831a9ff71..f9395cdeb11a8b3fa5bfdffb8f60dc86d082cc62 100644

--- a/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

+++ b/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

@@ -21,6 +21,7 @@

#include "components/password_manager/core/browser/browser_save_password_progress_logger.h"

#include "components/password_manager/core/browser/password_bubble_experiment.h"

#include "components/password_manager/core/browser/password_form_manager.h"

+#include "components/password_manager/core/browser/password_manager_constants.h"

#include "components/password_manager/core/browser/statistics_table.h"

#include "components/password_manager/core/common/credential_manager_types.h"

#include "content/public/browser/navigation_details.h"

@@ -303,20 +304,7 @@ void ManagePasswordsUIController::NavigateToExternalPasswordManager() {

#else

chrome::NavigateParams params(

chrome::FindBrowserWithWebContents(web_contents()),

- GURL(chrome::kPasswordManagerAccountDashboardURL),

- ui::PAGE_TRANSITION_LINK);

- params.disposition = NEW_FOREGROUND_TAB;

- chrome::Navigate(&params);

-#endif

-void ManagePasswordsUIController::NavigateToSmartLockPage() {

-#if defined(OS_ANDROID)

- NOTREACHED();

-#else

- chrome::NavigateParams params(

- chrome::FindBrowserWithWebContents(web_contents()),

- GURL(l10n_util::GetStringUTF16(IDS_PASSWORD_MANAGER_SMART_LOCK_PAGE)),

+ GURL(password_manager::kPasswordManagerAccountDashboardURL),

ui::PAGE_TRANSITION_LINK);

params.disposition = NEW_FOREGROUND_TAB;

chrome::Navigate(&params);