Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 1467943002: exo: Handle lost context situations properly. (Closed)

Created:
5 years, 1 month ago by reveman
Modified:
5 years, 1 month ago
Reviewers:
piman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

exo: Handle lost context situations properly. This implements proper handling of lost context by exosphere. It also improves support for software compositing by not crashing. True software compositing support will be added by follow up patches. BUG=549781 TEST=exo_unittests --gtest_filter=BufferTest.IsLost Committed: https://crrev.com/ced21f867a76bc4858a9b6530820c7962286c270 Cr-Commit-Position: refs/heads/master@{#361228}

Patch Set 1 #

Patch Set 2 : cleanup comments #

Total comments: 2

Patch Set 3 : move SharedMainThreadContextProvider #

Unified diffs Side-by-side diffs Delta from patch set Stats (+320 lines, -145 lines) Patch
M components/exo/buffer.h View 1 4 chunks +35 lines, -14 lines 0 comments Download
M components/exo/buffer.cc View 1 2 4 chunks +152 lines, -82 lines 0 comments Download
M components/exo/buffer_unittest.cc View 3 chunks +42 lines, -5 lines 0 comments Download
M components/exo/surface.h View 1 3 chunks +14 lines, -5 lines 0 comments Download
M components/exo/surface.cc View 1 4 chunks +67 lines, -27 lines 0 comments Download
M components/exo/surface_unittest.cc View 1 chunk +10 lines, -12 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1467943002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1467943002/20001
5 years, 1 month ago (2015-11-23 03:43:49 UTC) #2
reveman
5 years, 1 month ago (2015-11-23 03:43:54 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-23 03:56:09 UTC) #6
piman
lgtm https://codereview.chromium.org/1467943002/diff/20001/components/exo/buffer.cc File components/exo/buffer.cc (right): https://codereview.chromium.org/1467943002/diff/20001/components/exo/buffer.cc#newcode186 components/exo/buffer.cc:186: texture.reset(); I suggest doing this before getting the ...
5 years, 1 month ago (2015-11-23 21:04:42 UTC) #7
reveman
https://codereview.chromium.org/1467943002/diff/20001/components/exo/buffer.cc File components/exo/buffer.cc (right): https://codereview.chromium.org/1467943002/diff/20001/components/exo/buffer.cc#newcode186 components/exo/buffer.cc:186: texture.reset(); On 2015/11/23 at 21:04:42, piman (slow to review) ...
5 years, 1 month ago (2015-11-23 23:25:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1467943002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1467943002/40001
5 years, 1 month ago (2015-11-23 23:27:46 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-11-24 00:42:59 UTC) #12
commit-bot: I haz the power
5 years, 1 month ago (2015-11-24 00:43:40 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ced21f867a76bc4858a9b6530820c7962286c270
Cr-Commit-Position: refs/heads/master@{#361228}

Powered by Google App Engine
This is Rietveld 408576698