Install ConstructNonConstructable as construct stub for non-constructables.

Install ConstructNonConstructable as construct stub for non-constructables.

BUG=

Committed: https://crrev.com/8e28e851ee8aa60f7102433454e77934b4702715
Cr-Commit-Position: refs/heads/master@{#32223}

[Toon Verwaest, 2015-11-20 12:31:54]

verwaest@chromium.org changed reviewers:
+ ishell@chromium.org

[Toon Verwaest, 2015-11-20 12:31:54]

ptal

[Toon Verwaest, 2015-11-20 15:39:10]

Patchset #1 (id:1) has been deleted

[Toon Verwaest, 2015-11-20 15:56:16]

Patchset #1 (id:10001) has been deleted

[Toon Verwaest, 2015-11-20 15:56:21]

Patchset #1 (id:30001) has been deleted

[Toon Verwaest, 2015-11-20 15:56:26]

Patchset #1 (id:50001) has been deleted

[Toon Verwaest, 2015-11-20 15:56:31]

Patchset #1 (id:70001) has been deleted

[Michael Starzinger, 2015-11-20 16:00:23]

mstarzinger@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[Michael Starzinger, 2015-11-20 16:00:23]

LGTM on "compiler" part, didn't look at the rest.

[Toon Verwaest, 2015-11-20 16:10:02]

Patchset #1 (id:90001) has been deleted

[Igor Sheludko, 2015-11-23 08:48:56]

sgtm with one question:

In LiveEdit::ReplaceFunctionCode() we set construct stub to
JSConstructStubGeneric. Could it happen that after live edit session a non
constructable function become constructable?

https://codereview.chromium.org/1467473002/diff/110001/src/builtins.h
File src/builtins.h (right):

https://codereview.chromium.org/1467473002/diff/110001/src/builtins.h#newcode89
src/builtins.h:89: V(ConstructedNonConstructable, BUILTIN, UNINITIALIZED,
kNoExtraICState)     \
Please update the CL description.

[Toon Verwaest, 2015-11-24 09:17:40]

Description was changed from

==========
Install CalledNonCallable as construct stub for non-constructables.

BUG=
==========

to

==========
Install ConstructNonConstructable as construct stub for non-constructables.

BUG=
==========

[Igor Sheludko, 2015-11-24 14:08:14]

lgtm

[Toon Verwaest, 2015-11-24 16:57:06]

The CQ bit was checked by verwaest@chromium.org

[Toon Verwaest, 2015-11-24 16:57:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org, ishell@chromium.org
Link to the patchset: https://codereview.chromium.org/1467473002/#ps190001
(title: "Rebase")

[commit-bot: I haz the power, 2015-11-24 16:57:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1467473002/190001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1467473002/190001

[commit-bot: I haz the power, 2015-11-24 17:16:45]

Committed patchset #5 (id:190001)

[commit-bot: I haz the power, 2015-11-24 17:17:08]

Patchset 5 (id:??) landed as
https://crrev.com/8e28e851ee8aa60f7102433454e77934b4702715
Cr-Commit-Position: refs/heads/master@{#32223}