src/compiler/js-typed-lowering.cc - Issue 1467473002: Install ConstructNonConstructable as construct stub for non-constructables.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/js-typed-lowering.cc

Issue 1467473002: Install ConstructNonConstructable as construct stub for non-constructables. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Rebase Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler/js-typed-lowering.cc

diff --git a/src/compiler/js-typed-lowering.cc b/src/compiler/js-typed-lowering.cc

index 0df827add74fb0a9ecf2e17cb35eb0582084a802..696df5cccef882f9e8cd9b0340c272dcccbf2b01 100644

--- a/src/compiler/js-typed-lowering.cc

+++ b/src/compiler/js-typed-lowering.cc

@@ -1398,8 +1398,7 @@ Reduction JSTypedLowering::ReduceJSCreate(Node* node) {

target_type->AsConstant()->Value()->IsJSFunction()) {

Handle<JSFunction> constructor =

Handle<JSFunction>::cast(target_type->AsConstant()->Value());

- // Check that function is a constructor.

- if (!constructor->IsConstructor()) return NoChange();

+ DCHECK(constructor->IsConstructor());

// Force completion of inobject slack tracking before

// generating code to finalize the instance size.

if (constructor->IsInobjectSlackTrackingInProgress()) {

« no previous file with comments | « src/compiler/js-inlining.cc ('k') | src/debug/liveedit.cc » ('j') | no next file with comments »