src/runtime/runtime-classes.cc - Issue 1467473002: Install ConstructNonConstructable as construct stub for non-constructables.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-classes.cc

Issue 1467473002: Install ConstructNonConstructable as construct stub for non-constructables. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Rebase Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/runtime/runtime-classes.cc

diff --git a/src/runtime/runtime-classes.cc b/src/runtime/runtime-classes.cc

index 8ddd20db3dab6403c5c08da4d646ad3b31ee0268..c13e55eebf3387e7f60a5309dc85d60265e578d2 100644

--- a/src/runtime/runtime-classes.cc

+++ b/src/runtime/runtime-classes.cc

@@ -36,9 +36,11 @@ RUNTIME_FUNCTION(Runtime_ThrowUnsupportedSuperError) {

RUNTIME_FUNCTION(Runtime_ThrowConstructorNonCallableError) {

HandleScope scope(isolate);

- DCHECK(args.length() == 0);

+ DCHECK(args.length() == 1);

+ CONVERT_ARG_HANDLE_CHECKED(JSFunction, constructor, 0);

+ Handle<Object> name(constructor->shared()->name(), isolate);

THROW_NEW_ERROR_RETURN_FAILURE(

- isolate, NewTypeError(MessageTemplate::kConstructorNonCallable));

+ isolate, NewTypeError(MessageTemplate::kConstructorNonCallable, name));

}

« no previous file with comments | « src/runtime/runtime.h ('k') | src/runtime/runtime-function.cc » ('j') | no next file with comments »