Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1467453006: Deprecate FLAGS_reset_cubic_epoch_when_app_limited. (Closed)

Created:
5 years, 1 month ago by ianswett
Modified:
5 years ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@107709890
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Deprecate FLAGS_reset_cubic_epoch_when_app_limited. Merge internal change: 107711408 R=rch@chromium.org BUG=

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -18 lines) Patch
M net/quic/congestion_control/tcp_cubic_bytes_sender.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_bytes_sender_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/quic_flags.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/quic_flags.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M net/tools/quic/quic_server_bin.cc View 1 chunk +13 lines, -0 lines 2 comments Download

Depends on Patchset:

Issue 1464153002 Patch 1

Dependent Patchsets:

Issue 1472573002 Patch 1

Messages

Total messages: 4 (0 generated)
ianswett
5 years, 1 month ago (2015-11-21 22:32:37 UTC) #1
Ryan Hamilton
https://codereview.chromium.org/1467453006/diff/1/net/tools/quic/quic_server_bin.cc File net/tools/quic/quic_server_bin.cc (right): https://codereview.chromium.org/1467453006/diff/1/net/tools/quic/quic_server_bin.cc#newcode52 net/tools/quic/quic_server_bin.cc:52: >>>>>>> This looks like a merge conflict. You'll want ...
5 years, 1 month ago (2015-11-22 00:54:11 UTC) #2
ianswett
quic_server_bin fixed in Final. https://codereview.chromium.org/1467453006/diff/1/net/tools/quic/quic_server_bin.cc File net/tools/quic/quic_server_bin.cc (right): https://codereview.chromium.org/1467453006/diff/1/net/tools/quic/quic_server_bin.cc#newcode52 net/tools/quic/quic_server_bin.cc:52: >>>>>>> On 2015/11/22 00:54:10, Ryan ...
5 years ago (2015-11-23 20:04:06 UTC) #3
Ryan Hamilton
5 years ago (2015-11-23 20:53:26 UTC) #4 
lgtm

Powered by Google App Engine
This is Rietveld 408576698