net/quic/congestion_control/tcp_cubic_bytes_sender_test.cc - Issue 1467453006: Deprecate FLAGS_reset_cubic_epoch_when_app_limited.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/congestion_control/tcp_cubic_bytes_sender_test.cc

Issue 1467453006: Deprecate FLAGS_reset_cubic_epoch_when_app_limited. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@107709890

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « net/quic/congestion_control/tcp_cubic_bytes_sender.cc ('k') | net/quic/congestion_control/tcp_cubic_sender.cc » ('j') | net/tools/quic/quic_server_bin.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/quic/congestion_control/tcp_cubic_bytes_sender_test.cc

diff --git a/net/quic/congestion_control/tcp_cubic_bytes_sender_test.cc b/net/quic/congestion_control/tcp_cubic_bytes_sender_test.cc

index d1f14035009c0459425bdb7d68f1ce1671fc589b..70606dc3a82c3ce1ce7b2bcb8d1a56e44e26d965 100644

--- a/net/quic/congestion_control/tcp_cubic_bytes_sender_test.cc

+++ b/net/quic/congestion_control/tcp_cubic_bytes_sender_test.cc

@@ -402,7 +402,6 @@ TEST_F(TcpCubicBytesSenderTest, RetransmissionDelay) {

}

TEST_F(TcpCubicBytesSenderTest, TcpCubicResetEpochOnQuiescence) {

- ValueRestore<bool> old_flag(&FLAGS_reset_cubic_epoch_when_app_limited, true);

const int kMaxCongestionWindow = 50;

const QuicByteCount kMaxCongestionWindowBytes =

kMaxCongestionWindow * kDefaultTCPMSS;