Issue 1464153002: Add ConsumeData method to QuicPacketCreator, ConsumeData wraps both CreateStreamFrame and AddFrame.…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1464153002: Add ConsumeData method to QuicPacketCreator, ConsumeData wraps both CreateStreamFrame and AddFrame.… (Closed)

Created:
5 years, 1 month ago by ianswett

Modified:
5 years ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@107699435

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Add ConsumeData method to QuicPacketCreator, ConsumeData wraps both CreateStreamFrame and AddFrame. No functional change expected. Also move CreateStreamFrame from public to private in QuicPacketCreator. Merge internal change: 107709890 R=rch@chromium.org BUG=

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+140 lines, -95 lines)			Patch
M	net/quic/quic_packet_creator.h	View	2 chunks	+28 lines, -14 lines	0 comments	Download
M	net/quic/quic_packet_creator.cc	View	1 chunk	+16 lines, -0 lines	0 comments	Download
M	net/quic/quic_packet_creator_test.cc	View	14 chunks	+64 lines, -72 lines	0 comments	Download
M	net/quic/quic_packet_generator.cc	View	1 chunk	+10 lines, -9 lines	0 comments	Download
M	net/quic/test_tools/quic_packet_creator_peer.h	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	net/quic/test_tools/quic_packet_creator_peer.cc	View	1 chunk	+14 lines, -0 lines	0 comments	Download

Depends on Patchset:

Issue 1471583002 Patch 1

Dependent Patchsets:

Issue 1467453006 Patch 1

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages