Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issue 1467403002: Move Windows DC-initialization to skia_utils_win.h (Closed)

Created:
5 years, 1 month ago by tomhudson
Modified:
5 years ago
CC:
chromium-reviews, hal canary at chromium, tfarina, bungeman-chromium, sky, Lei Zhang
Base URL:
https://chromium.googlesource.com/chromium/src.git@move-metafile-from-device
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

We're getting rid of platform_device.h; most remaining users were in printing and had no relation to PlatformDevice, but just needed the Windows-specific InitializeDC() call. That call doesn't make any use of Skia, so could move elsewhere, but probably makes sense to leave in skia/ext/. Also removed were some unnecessary #includes of this platform- specific header. BUG=543755 R=bungeman@chromium.org,thestig@chromium.org TBR=sky@chromium.org Committed: https://crrev.com/828dddbb199eabef7cefe94a33bdd187470fef04 Cr-Commit-Position: refs/heads/master@{#363205}

Patch Set 1 #

Patch Set 2 : Windows-specific includes restored #

Patch Set 3 : Rebase? #

Patch Set 4 : Obviously missing windows include #

Patch Set 5 : More missing includes? #

Patch Set 6 : Rebase again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -53 lines) Patch
M printing/emf_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/image_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/printed_document_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/printing_context_system_dialog_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/printing_context_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M skia/ext/bitmap_platform_device_win.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M skia/ext/platform_device.h View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M skia/ext/platform_device_win.cc View 1 chunk +0 lines, -39 lines 0 comments Download
M skia/ext/skia_utils_win.h View 2 chunks +6 lines, -0 lines 0 comments Download
M skia/ext/skia_utils_win.cc View 1 chunk +39 lines, -0 lines 0 comments Download
M ui/views/background.cc View 1 2 3 4 1 chunk +4 lines, -2 lines 0 comments Download
M ui/views/controls/single_split_view.cc View 1 2 3 4 2 chunks +4 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 34 (20 generated)
Tom Hudson
5 years, 1 month ago (2015-11-23 20:31:14 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1467403002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1467403002/20001
5 years, 1 month ago (2015-11-23 20:39:46 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/126955) mac_chromium_gn_rel on ...
5 years, 1 month ago (2015-11-23 20:44:06 UTC) #5
hal.canary
LGTM (for what it is worth)
5 years ago (2015-11-24 14:54:59 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1467403002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1467403002/40001
5 years ago (2015-11-24 19:29:53 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/71107) win_chromium_compile_dbg_ng on ...
5 years ago (2015-11-24 20:13:07 UTC) #11
Tom Hudson
PTAL, all the prerequisite patches have landed.
5 years ago (2015-11-30 21:46:21 UTC) #17
tomhudson
Does Ben have spare cycles to look at this?
5 years ago (2015-12-03 18:42:27 UTC) #20
bungeman-skia
Skia part of this lgtm, but I think you'll need OWNERS for the outside Skia ...
5 years ago (2015-12-03 18:55:10 UTC) #22
bungeman-chromium
lgtm
5 years ago (2015-12-03 18:55:30 UTC) #23
Lei Zhang
printing/ lgtm
5 years ago (2015-12-03 19:57:05 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1467403002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1467403002/100001
5 years ago (2015-12-04 13:53:01 UTC) #30
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years ago (2015-12-04 14:34:23 UTC) #32
commit-bot: I haz the power
5 years ago (2015-12-04 14:35:28 UTC) #34
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/828dddbb199eabef7cefe94a33bdd187470fef04
Cr-Commit-Position: refs/heads/master@{#363205}

Powered by Google App Engine
This is Rietveld 408576698