Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1253)

Issue 1466463004: Aura on Android: Fix link errors when building content_unittests_apk. (Closed)

Created:
5 years, 1 month ago by Hadi
Modified:
5 years, 1 month ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@platform_window_mus
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Aura on Android: Fix link errors when building content_unittests_apk. * Do ui::RegisterUIAndroidJni() only when not using Aura. * Exclude desktop_aura from the build. BUG=507792 Committed: https://crrev.com/ce62351f189643118e9d09bf06e128b75345ef36 Cr-Commit-Position: refs/heads/master@{#360942}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M content/app/android/library_loader_hooks.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M content/public/test/content_test_suite_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 11 (2 generated)
Hadi
PTAL. This resolves the link errors we were getting when compiling content_unittests_apk. If we don't ...
5 years, 1 month ago (2015-11-20 19:11:31 UTC) #2
no sievers
lgtm
5 years, 1 month ago (2015-11-20 19:32:07 UTC) #3
mfomitchev
LGTM I've actually published the same change for views before seeing this: https://codereview.chromium.org/1467613002/ I'd be ...
5 years, 1 month ago (2015-11-20 21:30:16 UTC) #4
bshe
On 2015/11/20 21:30:16, mfomitchev wrote: > LGTM > I've actually published the same change for ...
5 years, 1 month ago (2015-11-20 21:50:12 UTC) #5
sadrul
lgtm
5 years, 1 month ago (2015-11-20 22:30:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1466463004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1466463004/1
5 years, 1 month ago (2015-11-20 23:05:30 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-20 23:17:22 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ce62351f189643118e9d09bf06e128b75345ef36 Cr-Commit-Position: refs/heads/master@{#360942}
5 years, 1 month ago (2015-11-20 23:18:17 UTC) #10
mfomitchev
4 years, 10 months ago (2016-01-27 21:28:41 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1647663002/ by mfomitchev@chromium.org.

The reason for reverting is: Reverting, since Android Aura has been cancelled.

Powered by Google App Engine
This is Rietveld 408576698