Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 1465933002: Aura on Android: Compile PlatformWindowMus. (Closed)

Created:
5 years, 1 month ago by Hadi
Modified:
5 years, 1 month ago
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Aura on Android: Compile PlatformWindowMus. AcceleratedWidget is defined as ANativeWindow on Android, so similar to windows, we need to do reinterpret_cast to cast an integer to it. BUG=507792 Committed: https://crrev.com/a622adbece3e6c76eeb884325bdb349fe4fc4056 Cr-Commit-Position: refs/heads/master@{#360874}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/views/mus/platform_window_mus.cc View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (2 generated)
Hadi
PTAL.
5 years, 1 month ago (2015-11-20 18:13:58 UTC) #2
mfomitchev
LGTM
5 years, 1 month ago (2015-11-20 18:15:03 UTC) #3
sadrul
lgtm
5 years, 1 month ago (2015-11-20 18:17:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1465933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1465933002/1
5 years, 1 month ago (2015-11-20 18:20:00 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-20 19:20:15 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-20 19:21:15 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a622adbece3e6c76eeb884325bdb349fe4fc4056
Cr-Commit-Position: refs/heads/master@{#360874}

Powered by Google App Engine
This is Rietveld 408576698