Fix missing data_store.pb.h error when building extensions GN target.

Fix the missing "data_store.pb.h" error when building extensions gn target on a clean output directory.

data_reduction_proxy_api.cc includes data_store.pb.h directly and indirectly (via data_reduction_proxy_compression_stats.h). This CL adds //components/data_reduction_proxy/proto:data_reduction_proxy_proto to the dependencies of extensions to solve this problem.

BUG=560321
Committed: https://crrev.com/4114e0891fc9688859706b54e35c6eb06c1f38c8
Cr-Commit-Position: refs/heads/master@{#361149}

[Hadi, 2015-11-20 22:21:33]

moshayedi@chromium.org changed reviewers:
+ mfomitchev@chromium.org, reillyg@chromium.org, sievers@chromium.org

[Hadi, 2015-11-20 22:21:33]

PTAL.

[Reilly Grant (use Gerrit), 2015-11-20 22:22:47]

lgtm

[Hadi, 2015-11-20 22:26:33]

The CQ bit was checked by moshayedi@chromium.org

[Hadi, 2015-11-20 22:26:39]

The CQ bit was unchecked by moshayedi@chromium.org

[mfomitchev, 2015-11-20 22:32:44]

From the description, it sounds like this would be an issue for non-Android
platforms as well, but all the other platforms build fine. This seems a bit
concerning.

[Hadi, 2015-11-20 23:05:40]

On 2015/11/20 22:32:44, mfomitchev wrote:
> From the description, it sounds like this would be an issue for non-Android
> platforms as well, but all the other platforms build fine. This seems a bit
> concerning.

You are right. I'll look into this deeper on Monday.

[Hadi, 2015-11-23 15:32:53]

On 2015/11/20 22:32:44, mfomitchev wrote:
> From the description, it sounds like this would be an issue for non-Android
> platforms as well, but all the other platforms build fine. This seems a bit
> concerning.

It seems that this problem exists in other gn platforms too. I verified that it
exists in Linux GN build. It's not a new problem, I could reproduce it when I
moved the head to 1 month ago.

The problem happens when you try to build the "extensions" gn target on a
**clean** build directory (i.e. a directory you haven't run ninja on any targets
before). The reason we were not observing this before was that we always built
some other targets before trying to build extensions, so the non-specified
dependencies were already built.

I'll create a bug report for this and update the description & title of this CL.

[Hadi, 2015-11-23 15:50:55]

Description was changed from

==========
Aura on Android: Add data_reduction_proxy/core/browser to
chrome/browser/extensions deps.

data_reduction_proxy_api.cc includes data_reduction_proxy_compression_stats.h
which is in data_reduction_proxy/core/browser.
Before fixing the dependencies, we were getting errors for missing
data_store.pb.h when trying to build the extensions gn
target for Aura on Android.

BUG=NONE
==========

to

==========
Fix the missing "data_store.pb.h" error when building extensions gn target on a
clean output directory.

data_reduction_proxy_api.cc includes data_store.pb.h directly and indirectly
(via data_reduction_proxy_compression_stats.h). This CL adds
components/data_reduction_proxy/proto to the dependencies of extensions to solve
this problem.

BUG=560321
==========

[Hadi, 2015-11-23 16:04:27]

Description was changed from

==========
Fix the missing "data_store.pb.h" error when building extensions gn target on a
clean output directory.

data_reduction_proxy_api.cc includes data_store.pb.h directly and indirectly
(via data_reduction_proxy_compression_stats.h). This CL adds
components/data_reduction_proxy/proto to the dependencies of extensions to solve
this problem.

BUG=560321
==========

to

==========
Fix the missing "data_store.pb.h" error when building extensions gn target on a
clean output directory.

data_reduction_proxy_api.cc includes data_store.pb.h directly and indirectly
(via data_reduction_proxy_compression_stats.h). This CL adds
//components/data_reduction_proxy/proto:data_reduction_proxy_proto to the
dependencies of extensions to solve this problem.

BUG=560321
==========

[Hadi, 2015-11-23 16:07:57]

On a second thought, I think adding
//components/data_reduction_proxy/proto:data_reduction_proxy_proto to
dependencies instead of //components/data_reduction_proxy/core/browser addresses
the problem more directly, although any of them solve the issue. I upload a
patch set with this change.

Does this look good to you?

[mfomitchev, 2015-11-23 18:31:57]

On 2015/11/23 16:07:57, Hadi wrote:
> On a second thought, I think adding
> //components/data_reduction_proxy/proto:data_reduction_proxy_proto to
> dependencies instead of //components/data_reduction_proxy/core/browser
addresses
> the problem more directly, although any of them solve the issue. I upload a
> patch set with this change.
> 
> Does this look good to you?

Sounds good, thanks for looking into this Hadi!

[Reilly Grant (use Gerrit), 2015-11-23 19:00:08]

lgtm

[Hadi, 2015-11-23 19:04:35]

The CQ bit was checked by moshayedi@chromium.org

[commit-bot: I haz the power, 2015-11-23 19:06:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1460313004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1460313004/20001

[commit-bot: I haz the power, 2015-11-23 19:24:06]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-23 19:25:52]

Patchset 2 (id:??) landed as
https://crrev.com/4114e0891fc9688859706b54e35c6eb06c1f38c8
Cr-Commit-Position: refs/heads/master@{#361149}