Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Unified Diff: cc/BUILD.gn

Issue 1466173002: Fix the `sizes` regressions in Linux GN. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@linux_x64_2
Patch Set: add TODOs Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/BUILD.gn
diff --git a/cc/BUILD.gn b/cc/BUILD.gn
index 3be4ebb9b3d28848b32687f46e4b15cac4b73044..0e243e4cf3b91e3563001711977d9df7a3d5bc4b 100644
--- a/cc/BUILD.gn
+++ b/cc/BUILD.gn
@@ -4,7 +4,10 @@
import("//testing/test.gni")
-component("cc") {
+static_library("cc") {
+ # TODO(crbug.com/559766) this should be a source_set but
+ # there are static initializers that get accidentally linked
Nico 2015/12/10 03:10:46 This one should be a component, actually
brettw 2015/12/10 18:48:36 components are source sets in the non-component bu
Dirk Pranke 2015/12/10 18:51:01 I think Nico was just pointing out that my comment
Nico 2015/12/10 18:52:03 Sure, but you can do this aynchronously after the
danakj 2015/12/10 19:20:31 cc/ is fixed by https://codereview.chromium.org/15
+ # into chrome from that need to be addressed first.
sources = [
"animation/animation.cc",
"animation/animation.h",

Powered by Google App Engine
This is Rietveld 408576698