Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 1515753003: Fix static initializers in cc/raster/texture_compressor_etc1_sse.cc (Closed)

Created:
5 years ago by radu.velea
Modified:
5 years ago
Reviewers:
danakj, reveman
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix static initializers in cc/raster/texture_compressor_etc1_sse.cc Perftests for *TextureCompressorPerfTest* Before: *RESULT Compress256x256BlackAndWhiteGradientImage: ETC1 Low= 1.0986825227737427 us *RESULT Compress256x256BlackAndWhiteGradientImage: ETC1 Medium= 1.0968447923660278 us *RESULT Compress256x256BlackAndWhiteGradientImage: ETC1 High= 1.0986814498901367 us *RESULT Compress256x256SolidBlackImage: ETC1 Low= .2650042474269867 us *RESULT Compress256x256SolidBlackImage: ETC1 Medium= .26646843552589417 us *RESULT Compress256x256SolidBlackImage: ETC1 High= .27297326922416687 us *RESULT Compress256x256SolidColorImage: ETC1 Low= .2867283523082733 us *RESULT Compress256x256SolidColorImage: ETC1 Medium= .28761234879493713 us *RESULT Compress256x256SolidColorImage: ETC1 High= .2860330045223236 us *RESULT Compress256x256RandomColorImage: ETC1 Low= 1.9297336339950562 us *RESULT Compress256x256RandomColorImage: ETC1 Medium= 1.9182685613632202 us *RESULT Compress256x256RandomColorImage: ETC1 High= 1.9214648008346558 us After: *RESULT Compress256x256BlackAndWhiteGradientImage: ETC1 Low= 1.0688649415969849 us *RESULT Compress256x256BlackAndWhiteGradientImage: ETC1 Medium= 1.0757253170013428 us *RESULT Compress256x256BlackAndWhiteGradientImage: ETC1 High= 1.077048420906067 us *RESULT Compress256x256SolidBlackImage: ETC1 Low= .26659414172172546 us *RESULT Compress256x256SolidBlackImage: ETC1 Medium= .2658853828907013 us *RESULT Compress256x256SolidBlackImage: ETC1 High= .26466891169548035 us *RESULT Compress256x256SolidColorImage: ETC1 Low= .2858351469039917 us *RESULT Compress256x256SolidColorImage: ETC1 Medium= .2861722409725189 us *RESULT Compress256x256SolidColorImage: ETC1 High= .2875249981880188 us *RESULT Compress256x256RandomColorImage: ETC1 Low= 1.8891329765319824 us *RESULT Compress256x256RandomColorImage: ETC1 Medium= 1.8881990909576416 us *RESULT Compress256x256RandomColorImage: ETC1 High= 1.8776999711990356 us Unittests for *TextureCompressorETC1Test* Note: Google Test filter = TextureCompressorETC1Test.Compress256x256Ratio [==========] Running 1 test from 1 test case. [----------] Global test environment set-up. [----------] 1 test from TextureCompressorETC1Test [ RUN ] TextureCompressorETC1Test.Compress256x256Ratio [ OK ] TextureCompressorETC1Test.Compress256x256Ratio (1 ms) [----------] 1 test from TextureCompressorETC1Test (1 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test case ran. (2 ms total) [ PASSED ] 1 test. [1/1] TextureCompressorETC1Test.Compress256x256Ratio (1 ms) SUCCESS: all tests passed. Tests took 0 seconds. BUG=568332 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/bf9f7f7b3d8deb378d0550ffd706be812978073f Cr-Commit-Position: refs/heads/master@{#364379}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -11 lines) Patch
M cc/raster/texture_compressor_etc1_sse.cc View 4 chunks +7 lines, -11 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
reveman
lgtm, we can always try to get that minor performance regression back using a follow ...
5 years ago (2015-12-10 14:13:42 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1515753003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1515753003/1
5 years ago (2015-12-10 14:18:13 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/80475)
5 years ago (2015-12-10 15:58:13 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1515753003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1515753003/1
5 years ago (2015-12-10 16:00:50 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-10 16:45:04 UTC) #14
commit-bot: I haz the power
5 years ago (2015-12-10 16:46:09 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bf9f7f7b3d8deb378d0550ffd706be812978073f
Cr-Commit-Position: refs/heads/master@{#364379}

Powered by Google App Engine
This is Rietveld 408576698