Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Side by Side Diff: cc/BUILD.gn

Issue 1466173002: Fix the `sizes` regressions in Linux GN. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@linux_x64_2
Patch Set: add TODOs Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//testing/test.gni") 5 import("//testing/test.gni")
6 6
7 component("cc") { 7 static_library("cc") {
8 # TODO(crbug.com/559766) this should be a source_set but
9 # there are static initializers that get accidentally linked
Nico 2015/12/10 03:10:46 This one should be a component, actually
brettw 2015/12/10 18:48:36 components are source sets in the non-component bu
Dirk Pranke 2015/12/10 18:51:01 I think Nico was just pointing out that my comment
Nico 2015/12/10 18:52:03 Sure, but you can do this aynchronously after the
danakj 2015/12/10 19:20:31 cc/ is fixed by https://codereview.chromium.org/15
10 # into chrome from that need to be addressed first.
8 sources = [ 11 sources = [
9 "animation/animation.cc", 12 "animation/animation.cc",
10 "animation/animation.h", 13 "animation/animation.h",
11 "animation/animation_curve.cc", 14 "animation/animation_curve.cc",
12 "animation/animation_curve.h", 15 "animation/animation_curve.h",
13 "animation/animation_delegate.h", 16 "animation/animation_delegate.h",
14 "animation/animation_events.cc", 17 "animation/animation_events.cc",
15 "animation/animation_events.h", 18 "animation/animation_events.h",
16 "animation/animation_host.cc", 19 "animation/animation_host.cc",
17 "animation/animation_host.h", 20 "animation/animation_host.h",
(...skipping 957 matching lines...) Expand 10 before | Expand all | Expand 10 after
975 "//ui/gl", 978 "//ui/gl",
976 "//ui/gl:test_support", 979 "//ui/gl:test_support",
977 ] 980 ]
978 981
979 if (is_android) { 982 if (is_android) {
980 isolate_file = "cc_perftests.isolate" 983 isolate_file = "cc_perftests.isolate"
981 } 984 }
982 } 985 }
983 # When adding support for isolates, please have a look at run-time dependencies 986 # When adding support for isolates, please have a look at run-time dependencies
984 # in the cc_unittests_run target in cc_tests.gyp. 987 # in the cc_unittests_run target in cc_tests.gyp.
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698