Fixed sync on OS X v10.6 (Snow Leopard).

Fixed sync on OS X v10.6 (Snow Leopard).

'gclient sync' tries to find 10.6 SDK on Mac OS X, but on Mac OS X
v10.6.8 (Snow Leopard) it fails with the error which looks like as
follows:

________ running '/usr/bin/python src/build/gyp_chromium' in '...'
2014-02-09 10:43:53.719 gn[61547:903] *** __NSAutoreleaseNoPool(): Object 0x20ca20 of class NSThread autoreleased with no pool in place - just leaking
ERROR at //build/config/mac/mac_sdk.gni:24:5: Script returned non-zero exit code.
    exec_script("//build/mac/find_sdk.py", find_sdk_args, "list lines")
    ^----------
Current dir: /Users/vm/Projects/src/out/gn_build.Release/
Command: python /Users/vm/Projects/src/build/mac/find_sdk.py --print_sdk_path 10.6
Returned 1.

The thing is Mac OS X v10.6.8 was shipped with Python 2.6.1, for which
subprosess.check_output is not defined, since it appeared starting from
Python 2.7, so it has been changed to subprosess.Popen

R=brettw@chromium.org
BUG=

[brettw, 2014-02-11 19:20:34]

I thought we required Python 2.7 now for everything. Adding maruel for
verification. If this is not true there are a whole bunch of check_output cases
that need to be changed.

[M-A Ruel, 2014-02-11 19:50:10]

On 2014/02/11 19:20:34, brettw wrote:
> I thought we required Python 2.7 now for everything. Adding maruel for
> verification. If this is not true there are a whole bunch of check_output
cases
> that need to be changed.

On OSX 10.6, python 2.7 must be manually installed. All our OSX slaves on 10.6
have python 2.7. So I recommend against this CL since many other things will
break.

[vmagaziy, 2014-02-11 19:56:31]

On 2014/02/11 19:50:10, M-A Ruel wrote:
> On 2014/02/11 19:20:34, brettw wrote:
> > I thought we required Python 2.7 now for everything. Adding maruel for
> > verification. If this is not true there are a whole bunch of check_output
> cases
> > that need to be changed.
> 
> On OSX 10.6, python 2.7 must be manually installed. All our OSX slaves on 10.6
> have python 2.7. So I recommend against this CL since many other things will
> break.

All right, I just haven't found this requirement, all instructions just mention
it has to have 10.6 along with Xcode 3.2.6 installed and that's it.  Is it
possible to mention this at the wiki page
https://code.google.com/p/chromium/wiki/MacBuildInstructions?

Could the following error I experience running ninja have the same roots?

***

$  ninja -C out/Debug chrome
ninja: Entering directory `out/Debug'
[6/14699] LIBTOOL-STATIC libaudio_processing_sse2.a, POSTBUILDS
FAILED: rm -f libaudio_processing_sse2.a && ./gyp-mac-tool filter-libtool
libtool  -static -o libaudio_processing_sse2.a
obj/third_party/webrtc/modules/audio_processing/aec/audio_processing_sse2.aec_core_sse2.o
obj/third_party/webrtc/modules/audio_processing/aec/audio_processing_sse2.aec_rdft_sse2.o
  File "./gyp-mac-tool", line 507
    return {k: self._ExpandVariables(data[k], substitutions) for k in data}
                                                               ^
SyntaxError: invalid syntax
[6/14699] ACTION Generating resources from ui_strings.grd
ninja: build stopped: subcommand failed.

[M-A Ruel, 2014-02-11 20:09:22]

On 2014/02/11 19:56:31, vmagaziy wrote:
> On 2014/02/11 19:50:10, M-A Ruel wrote:
> All right, I just haven't found this requirement, all instructions just
mention
> it has to have 10.6 along with Xcode 3.2.6 installed and that's it.  Is it
> possible to mention this at the wiki page
> https://code.google.com/p/chromium/wiki/MacBuildInstructions?

I updated the page.


> Could the following error I experience running ninja have the same roots?
> 
> ***
> 
> $  ninja -C out/Debug chrome
> ninja: Entering directory `out/Debug'
> [6/14699] LIBTOOL-STATIC libaudio_processing_sse2.a, POSTBUILDS
> FAILED: rm -f libaudio_processing_sse2.a && ./gyp-mac-tool filter-libtool
> libtool  -static -o libaudio_processing_sse2.a
>
obj/third_party/webrtc/modules/audio_processing/aec/audio_processing_sse2.aec_core_sse2.o
>
obj/third_party/webrtc/modules/audio_processing/aec/audio_processing_sse2.aec_rdft_sse2.o
>   File "./gyp-mac-tool", line 507
>     return {k: self._ExpandVariables(data[k], substitutions) for k in data}
>                                                                ^
> SyntaxError: invalid syntax
> [6/14699] ACTION Generating resources from ui_strings.grd
> ninja: build stopped: subcommand failed.

Yes, it is a 2.7 syntax.

[vmagaziy, 2014-02-11 20:11:14]

On 2014/02/11 20:09:22, M-A Ruel wrote:
> On 2014/02/11 19:56:31, vmagaziy wrote:
> > On 2014/02/11 19:50:10, M-A Ruel wrote:
> > All right, I just haven't found this requirement, all instructions just
> mention
> > it has to have 10.6 along with Xcode 3.2.6 installed and that's it.  Is it
> > possible to mention this at the wiki page
> > https://code.google.com/p/chromium/wiki/MacBuildInstructions?
> 
> I updated the page.
> 
> 
> > Could the following error I experience running ninja have the same roots?
> > 
> > ***
> > 
> > $  ninja -C out/Debug chrome
> > ninja: Entering directory `out/Debug'
> > [6/14699] LIBTOOL-STATIC libaudio_processing_sse2.a, POSTBUILDS
> > FAILED: rm -f libaudio_processing_sse2.a && ./gyp-mac-tool filter-libtool
> > libtool  -static -o libaudio_processing_sse2.a
> >
>
obj/third_party/webrtc/modules/audio_processing/aec/audio_processing_sse2.aec_core_sse2.o
> >
>
obj/third_party/webrtc/modules/audio_processing/aec/audio_processing_sse2.aec_rdft_sse2.o
> >   File "./gyp-mac-tool", line 507
> >     return {k: self._ExpandVariables(data[k], substitutions) for k in data}
> >                                                                ^
> > SyntaxError: invalid syntax
> > [6/14699] ACTION Generating resources from ui_strings.grd
> > ninja: build stopped: subcommand failed.
> 
> Yes, it is a 2.7 syntax.

Thanks a lot!