Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: build/mac/find_sdk.py

Issue 146613006: Fixed sync on OS X v10.6 (Snow Leopard). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/mac/find_sdk.py
diff --git a/build/mac/find_sdk.py b/build/mac/find_sdk.py
index 1d7634391fa4d66b2baeec276429836c39d53283..30cb57153f902f6e7eb177867d2cffc45a5ae104 100755
--- a/build/mac/find_sdk.py
+++ b/build/mac/find_sdk.py
@@ -77,8 +77,16 @@ def main():
return min_sdk_version
if options.print_sdk_path:
- print subprocess.check_output(['xcodebuild', '-version', '-sdk',
- 'macosx' + best_sdk, 'Path']).strip()
+ job = subprocess.Popen(['xcodebuild', '-version', '-sdk',
+ 'macosx' + best_sdk, 'Path'],
+ stdout=subprocess.PIPE,
+ stderr=subprocess.STDOUT)
+ out, err = job.communicate()
+ if job.returncode != 0:
+ print >>sys.stderr, out
+ print >>sys.stderr, err
+ raise Exception('No %s SDK found' % best_sdk)
+ print out.strip()
return best_sdk
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698