Fix for perf Regression in SVG with Fragment URIs

Fix for perf regression in SVG with Fragment URIs.

Early return , fragment URI if baseURL and document URL matches.
It fixes the SVGNestedUse test perf regression.

BUG=557979
Committed: https://crrev.com/e2cd3ac60aa4d76a599f66f529a8fb81b262f3b0
Cr-Commit-Position: refs/heads/master@{#360805}

[Shanmuga Pandi, 2015-11-20 11:23:08]

Description was changed from

==========
Fix for Regression in SVG with Fragment URIs

Early return , fragment URI if baseURL and document URL matches.
It fixes the SVGNestedUse test regression.

BUG=557979
==========

to

==========
Fix for Regression in SVG with Fragment URIs

Early return , fragment URI if baseURL and document URL matches.
It fixes the SVGNestedUse test regression.

BUG=557979
==========

[Shanmuga Pandi, 2015-11-20 11:23:08]

shanmuga.m@samsung.com changed reviewers:
+ ed@chromium.org, fs@opera.com, pdr@chromium.org

[Shanmuga Pandi, 2015-11-20 11:24:06]

Please check this!!

[fs, 2015-11-20 11:48:36]

LGTM w/ nits.

I also suggest changing "regression" in the description to "performance
regression" for clarity. (Can be shortened to "perf regression" if the full term
is too wide, but I don't think that'll be needed.)

https://codereview.chromium.org/1465833002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/svg/SVGURIReference.h (right):

https://codereview.chromium.org/1465833002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/svg/SVGURIReference.h:44: // Fragment-only URIs
are always internal, if baseURL matches with document URL
Nit: Remove ',', and add '.' at the end. While we're at it: "baseURL matches
with document" -> "the base URL is the same as the document"

https://codereview.chromium.org/1465833002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/svg/SVGURIReference.h:45: // This early check
fixes the performance regression crbug.com/557979
Nit: I'd suggest something more like:

"This is a common case, so check that first to avoid resolving the URL (which is
relatively expensive). See crbug.com/..."

[Shanmuga Pandi, 2015-11-20 11:56:29]

Description was changed from

==========
Fix for Regression in SVG with Fragment URIs

Early return , fragment URI if baseURL and document URL matches.
It fixes the SVGNestedUse test regression.

BUG=557979
==========

to

==========
Fix for perf regression in SVG with Fragment URIs.

Early return , fragment URI if baseURL and document URL matches.
It fixes the SVGNestedUse test perf regression.

BUG=557979
==========

[Shanmuga Pandi, 2015-11-20 12:02:11]

The CQ bit was checked by shanmuga.m@samsung.com

[Shanmuga Pandi, 2015-11-20 12:02:12]

The patchset sent to the CQ was uploaded after l-g-t-m from fs@opera.com
Link to the patchset: https://codereview.chromium.org/1465833002/#ps20001
(title: "fixed nits")

[commit-bot: I haz the power, 2015-11-20 12:02:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1465833002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1465833002/20001

[commit-bot: I haz the power, 2015-11-20 13:04:10]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-20 13:05:00]

Patchset 2 (id:??) landed as
https://crrev.com/e2cd3ac60aa4d76a599f66f529a8fb81b262f3b0
Cr-Commit-Position: refs/heads/master@{#360805}