Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 /* | 1 /* |
| 2 * Copyright (C) 2004, 2005, 2008, 2009 Nikolas Zimmermann <zimmermann@kde.org> | 2 * Copyright (C) 2004, 2005, 2008, 2009 Nikolas Zimmermann <zimmermann@kde.org> |
| 3 * Copyright (C) 2004, 2005 Rob Buis <buis@kde.org> | 3 * Copyright (C) 2004, 2005 Rob Buis <buis@kde.org> |
| 4 * | 4 * |
| 5 * This library is free software; you can redistribute it and/or | 5 * This library is free software; you can redistribute it and/or |
| 6 * modify it under the terms of the GNU Library General Public | 6 * modify it under the terms of the GNU Library General Public |
| 7 * License as published by the Free Software Foundation; either | 7 * License as published by the Free Software Foundation; either |
| 8 * version 2 of the License, or (at your option) any later version. | 8 * version 2 of the License, or (at your option) any later version. |
| 9 * | 9 * |
| 10 * This library is distributed in the hope that it will be useful, | 10 * This library is distributed in the hope that it will be useful, |
| (...skipping 23 matching lines...) Expand all Loading... | |
| 34 public: | 34 public: |
| 35 virtual ~SVGURIReference() { } | 35 virtual ~SVGURIReference() { } |
| 36 | 36 |
| 37 bool isKnownAttribute(const QualifiedName&); | 37 bool isKnownAttribute(const QualifiedName&); |
| 38 | 38 |
| 39 static AtomicString fragmentIdentifierFromIRIString(const String&, const Tre eScope&); | 39 static AtomicString fragmentIdentifierFromIRIString(const String&, const Tre eScope&); |
| 40 static Element* targetElementFromIRIString(const String&, const TreeScope&, AtomicString* = 0, Document* = 0); | 40 static Element* targetElementFromIRIString(const String&, const TreeScope&, AtomicString* = 0, Document* = 0); |
| 41 | 41 |
| 42 static inline bool isExternalURIReference(const String& uri, const Document& document) | 42 static inline bool isExternalURIReference(const String& uri, const Document& document) |
| 43 { | 43 { |
| 44 // Fragment-only URIs are always internal, if baseURL matches with docum ent URL | |
|
fs
2015/11/20 11:48:36
Nit: Remove ',', and add '.' at the end. While we'
| |
| 45 // This early check fixes the performance regression crbug.com/557979 | |
|
fs
2015/11/20 11:48:36
Nit: I'd suggest something more like:
"This is a
| |
| 46 if (document.baseURL() == document.url() && uri.startsWith('#')) | |
| 47 return false; | |
| 48 | |
| 44 // If the URI matches our documents URL, we're dealing with a local refe rence. | 49 // If the URI matches our documents URL, we're dealing with a local refe rence. |
| 45 KURL url = document.completeURL(uri); | 50 KURL url = document.completeURL(uri); |
| 46 return !equalIgnoringFragmentIdentifier(url, document.url()); | 51 return !equalIgnoringFragmentIdentifier(url, document.url()); |
| 47 } | 52 } |
| 48 | 53 |
| 49 const String& hrefString() const { return m_href->currentValue()->value(); } | 54 const String& hrefString() const { return m_href->currentValue()->value(); } |
| 50 | 55 |
| 51 // JS API | 56 // JS API |
| 52 SVGAnimatedString* href() const { return m_href.get(); } | 57 SVGAnimatedString* href() const { return m_href.get(); } |
| 53 | 58 |
| 54 DECLARE_VIRTUAL_TRACE(); | 59 DECLARE_VIRTUAL_TRACE(); |
| 55 | 60 |
| 56 protected: | 61 protected: |
| 57 explicit SVGURIReference(SVGElement*); | 62 explicit SVGURIReference(SVGElement*); |
| 58 | 63 |
| 59 private: | 64 private: |
| 60 RefPtrWillBeMember<SVGAnimatedString> m_href; | 65 RefPtrWillBeMember<SVGAnimatedString> m_href; |
| 61 }; | 66 }; |
| 62 | 67 |
| 63 } // namespace blink | 68 } // namespace blink |
| 64 | 69 |
| 65 #endif // SVGURIReference_h | 70 #endif // SVGURIReference_h |
| OLD | NEW |