Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: third_party/WebKit/Source/core/svg/SVGURIReference.h

Issue 1465833002: Fix for perf Regression in SVG with Fragment URIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixed nits Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/svg/SVGURIReference.h
diff --git a/third_party/WebKit/Source/core/svg/SVGURIReference.h b/third_party/WebKit/Source/core/svg/SVGURIReference.h
index 7174a3b6b4d5b3ebc82767ccaa7d095c09751271..b676bd33a1b6a394bf5786108b4f210598539907 100644
--- a/third_party/WebKit/Source/core/svg/SVGURIReference.h
+++ b/third_party/WebKit/Source/core/svg/SVGURIReference.h
@@ -41,6 +41,11 @@ public:
static inline bool isExternalURIReference(const String& uri, const Document& document)
{
+ // Fragment-only URIs are always internal if the baseURL is same as the document URL.
+ // This is common case, so check that first to avoid resolving URL (which is relatively expensive). See crbug.com/557979
+ if (document.baseURL() == document.url() && uri.startsWith('#'))
+ return false;
+
// If the URI matches our documents URL, we're dealing with a local reference.
KURL url = document.completeURL(uri);
return !equalIgnoringFragmentIdentifier(url, document.url());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698