Issue 1465583002: Convert QuicPathIdPacketNumber struct to std::pair. Not used in production, no behavior change.

Issue 1465583002: Convert QuicPathIdPacketNumber struct to std::pair. Not used in production, no behavior change. (Closed)

Created:
5 years, 1 month ago by ianswett

Modified:
5 years ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@107452913

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Convert QuicPathIdPacketNumber struct to std::pair. Not used in production, no behavior change. Chromium doesn't have the same support for custom hash functions. Makes it hard to port cl/106938391. Merge internal change: 107505890 R=rch@chromium.org BUG=

Patch Set 1 #

Total comments: 2

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	net/quic/quic_multipath_transmissions_map.h	View		1 chunk	+1 line, -1 line	2 comments	Download

Depends on Patchset:

Issue 1458003004 Patch 1

Dependent Patchsets:

Issue 1463603002 Patch 1

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ryan Hamilton

https://codereview.chromium.org/1465583002/diff/1/net/quic/quic_multipath_transmissions_map.h File net/quic/quic_multipath_transmissions_map.h (left): https://codereview.chromium.org/1465583002/diff/1/net/quic/quic_multipath_transmissions_map.h#oldcode26 net/quic/quic_multipath_transmissions_map.h:26: class NET_EXPORT_PRIVATE QuicMultipathTransmissionsMap { I'm pretty sure you don't ...

5 years, 1 month ago (2015-11-19 20:13:51 UTC) #2

ianswett

Fixed in the code, let's see if this works. https://codereview.chromium.org/1465583002/diff/1/net/quic/quic_multipath_transmissions_map.h File net/quic/quic_multipath_transmissions_map.h (left): https://codereview.chromium.org/1465583002/diff/1/net/quic/quic_multipath_transmissions_map.h#oldcode26 net/quic/quic_multipath_transmissions_map.h:26: ...

5 years, 1 month ago (2015-11-23 18:15:18 UTC) #3

lgtm

Expand Messages | Collapse Messages