Issue 1463603002: QUIC proof source: allow construction with an |SSLContext| provider.

Issue 1463603002: QUIC proof source: allow construction with an |SSLContext| provider. (Closed)

Created:
5 years, 1 month ago by ianswett

Modified:
5 years ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@107505890

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

QUIC proof source: allow construction with an |SSLContext| provider. To support |SSLContext| swaps, the long-lived |ProofSourceGoogle3| object must have a means of retrieving the new context. The simplest way to do that seems to be to pass in a getter method: the alternative of calling |SSLGlobalData::ssl_context| is unavailable due to circular dependencies. n/a (Refactor. No functional change expected.) Merge internal change: 107509393 R=rch@chromium.org BUG=

Patch Set 1 #

Total comments: 2

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -0 lines)			Patch
	M	net/tools/quic/quic_server_bin.cc	View		1 chunk	+13 lines, -0 lines	2 comments	Download

Depends on Patchset:

Issue 1465583002 Patch 1

Dependent Patchsets:

Issue 1466693002 Patch 1

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ryan Hamilton

https://codereview.chromium.org/1463603002/diff/1/net/tools/quic/quic_server_bin.cc File net/tools/quic/quic_server_bin.cc (right): https://codereview.chromium.org/1463603002/diff/1/net/tools/quic/quic_server_bin.cc#newcode42 net/tools/quic/quic_server_bin.cc:42: >>>>>>> Merge conflict?

5 years, 1 month ago (2015-11-19 20:14:16 UTC) #2

ianswett

Fixed in Final. https://codereview.chromium.org/1463603002/diff/1/net/tools/quic/quic_server_bin.cc File net/tools/quic/quic_server_bin.cc (right): https://codereview.chromium.org/1463603002/diff/1/net/tools/quic/quic_server_bin.cc#newcode42 net/tools/quic/quic_server_bin.cc:42: >>>>>>> On 2015/11/19 20:14:15, Ryan Hamilton ...

5 years, 1 month ago (2015-11-23 19:11:14 UTC) #3

Done in final, right?

LGTM

Expand Messages | Collapse Messages