Issue 1458003004: Fix bug in ReliableQuicStream::WritevData() where if the write failed and the connection was closed…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1458003004: Fix bug in ReliableQuicStream::WritevData() where if the write failed and the connection was closed… (Closed)

Created:
5 years, 1 month ago by ianswett

Modified:
5 years ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@107427162

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix bug in ReliableQuicStream::WritevData() where if the write failed and the connection was closed, the stream would attempt to mark itself write blocked leading to a crash in debug mode. Merge internal change: 107452913 R=rch@chromium.org BUG=

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -2 lines)			Patch
M	net/quic/quic_connection.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	net/quic/reliable_quic_stream.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	net/quic/reliable_quic_stream_test.cc	View	3 chunks	+25 lines, -0 lines	0 comments	Download

Dependent Patchsets:

Issue 1465583002 Patch 1

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages