[Storage] Android - ManageSpace UI, Important Origins, and CBD Dialog

chrome/android/java/res/layout/list_row_checked_icon.xml

Index: chrome/android/java/res/layout/list_row_checked_icon.xml
diff --git a/chrome/android/java/res/layout/list_row_checked_icon.xml b/chrome/android/java/res/layout/list_row_checked_icon.xml
new file mode 100644
index 0000000000000000000000000000000000000000..7a0474a34136a840846239e1a5633bab129e4973
--- /dev/null
+++ b/chrome/android/java/res/layout/list_row_checked_icon.xml
@@ -0,0 +1,28 @@
+<?xml version="1.0" encoding="utf-8"?>

[Theresa, 2016/05/12 20:22:41]

Instead of making this a generic list row, I think a layout for the important
sites makes sense. It's unlikely this exact configuration will be needed
somewhere else w/ the exact same padding, etc.

This file could be named confirm_important_sites_list_row.xml.

Rather than a RelativeLayout it can be a horizontal LinearLayout. The ImageView
will get specific width & height matching the favicon size, and the Checkbox
will get layout_width="0dp" and layout_weight="1".

data_reduction_stats_layout.xml has some good examples.

[dmurph, 2016/05/13 23:46:22]

Done.

+<!-- Copyright 2016 The Chromium Authors. All rights reserved.
+     Use of this source code is governed by a BSD-style license that can be
+     found in the LICENSE file. -->
+
+<RelativeLayout
+    xmlns:android="http://schemas.android.com/apk/res/android"
+    android:layout_width="match_parent"
+    android:layout_height="wrap_content"
+    android:minHeight="?attr/listPreferredItemHeightSmall" 
+    android:padding="5dp">
+    <CheckBox
+        android:id="@+id/icon_row_checkbox"
+        android:layout_width="wrap_content"
+        android:layout_height="wrap_content"

[Theresa, 2016/05/12 20:22:41]

Should this height be match_parent so that it doesn't wrap to two lines? Or does
this screen allow wrapping?

[dmurph, 2016/05/13 23:46:22]

match_parent is fine.

+        android:layout_alignParentStart="true"
+        android:layout_toStartOf="@+id/icon_row_image"
+        android:textAppearance="?android:attr/textAppearanceMedium"
+        android:layout_centerVertical="true"
+        android:textColor="?attr/textColorAlertDialogListItem"/>
+    <ImageView
+        android:id="@+id/icon_row_image"
+        android:layout_width="wrap_content"
+        android:layout_height="wrap_content"

[Theresa, 2016/05/12 20:22:41]

I think this should be match_parent

[dmurph, 2016/05/13 23:46:22]

done.

+        android:layout_alignParentEnd="true"
+        android:layout_centerVertical="true"
+        android:padding="5dp" />

[Theresa, 2016/05/12 20:22:41]

If the size of the icon doesn't exactly match the size of the ImageView, add
android:scaleType="center"

[dmurph, 2016/05/13 23:46:22]

done.

+</RelativeLayout>