[Storage] Android - ManageSpace UI, Important Origins, and CBD Dialog

chrome/android/java/res/layout/manage_space_activity.xml

Index: chrome/android/java/res/layout/manage_space_activity.xml
diff --git a/chrome/android/java/res/layout/manage_space_activity.xml b/chrome/android/java/res/layout/manage_space_activity.xml
new file mode 100644
index 0000000000000000000000000000000000000000..900d09b2ace6360bce39b0dedc028affe072d111
--- /dev/null
+++ b/chrome/android/java/res/layout/manage_space_activity.xml
@@ -0,0 +1,100 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!-- Copyright 2016 The Chromium Authors. All rights reserved.
+     Use of this source code is governed by a BSD-style license that can be
+     found in the LICENSE file. -->
+
+<ScrollView
+    xmlns:android="http://schemas.android.com/apk/res/android"
+    android:id="@+id/main_scroll_view"
+    android:layout_width="match_parent"
+    android:layout_height="match_parent" >
+
+    <LinearLayout
+        android:id="@+id/main_view"
+        android:layout_width="match_parent"
+        android:layout_height="match_parent"
+        android:layout_marginStart="16dp"
+        android:layout_marginEnd="16dp"
+        android:orientation="vertical"
+        android:paddingStart="6dp"
+        android:paddingEnd="6dp"
+        android:paddingTop="5dp"
+        android:paddingBottom="5dp">
+
+        <!-- ======== 'Unimportant Storage' Info ======== -->
+        <TextView
+            android:id="@+id/unimportant_site_data_description"
+            android:text="@string/storage_management_unimportant_site_data_descriptive_text"
+            style="@style/ManageSpaceActivityExplanationTextView" />
+
+        <RelativeLayout

[Theresa, 2016/05/12 20:22:41]

LinearLayout's with weights are slightly more efficient than RelativeLayouts
since RelativeLayouts have to measure things twice to know how to draw them on
the screen. This layout is simple enough I think the RelativeLayout is okay,
just something to be aware of for future changes :)

[dmurph, 2016/05/13 23:46:22]

ok, thanks!

[Theresa, 2016/05/14 00:05:38]

I was taking an overly simple view on this; I think RelativeLayout makes sense
here. Nested RelativeLayouts are bad, but this is fine.

More background on view efficiency:
http://stackoverflow.com/questions/4069037/android-is-a-relativelayout-more-e...

http://developer.android.com/intl/in/training/improving-layouts/optimizing-la...

+            android:layout_width="match_parent"
+            android:layout_height="wrap_content"
+            android:baselineAligned="true">
+
+            <TextView
+                android:id="@+id/unimportant_site_data_size_prefix"
+                android:text="@string/storage_management_unimportant_site_data_size_label"
+                android:layout_alignParentStart="true"
+                style="@style/ManageSpaceActivitySizeTextView" />
+
+            <TextView
+                android:id="@+id/unimportant_site_data_storage_size_text"
+                android:layout_alignParentEnd="true"
+                style="@style/ManageSpaceActivitySizeTextView" />
+        </RelativeLayout>
+
+        <Button
+            android:id="@+id/clear_unimportant_site_data_storage"
+            android:text="@string/storage_management_clear_unimportant_site_data_button"
+            style="@style/ManageSpaceActivityButton" />
+
+
+        <!-- ======== Site Storage Info ======== -->
+        <TextView
+            android:id="@+id/site_data_description"
+            android:text="@string/storage_management_site_data_descriptive_text"
+            style="@style/ManageSpaceActivityExplanationTextView" />
+
+        <RelativeLayout
+            android:layout_width="match_parent"
+            android:layout_height="wrap_content"
+            android:baselineAligned="true">
+
+            <TextView
+                android:id="@+id/site_data_size_prefix"
+                android:text="@string/storage_management_site_data_size_label"
+                android:layout_alignParentStart="true"
+                style="@style/ManageSpaceActivitySizeTextView" />
+
+            <TextView
+                android:id="@+id/site_data_storage_size_text"
+                android:layout_alignParentEnd="true"
+                style="@style/ManageSpaceActivitySizeTextView" />
+        </RelativeLayout>
+
+        <Button
+            android:id="@+id/manage_site_data_storage"
+            android:text="@string/storage_management_manage_site_data_button"
+                style="@style/ManageSpaceActivityButton" />
+
+        <!-- ======== Global storage info ======== -->
+        <LinearLayout
+            android:id="@+id/clear_all_data_section"
+            android:orientation="vertical"
+            android:layout_width="match_parent"
+            android:layout_height="wrap_content" 
+            android:paddingTop="12dp">
+
+            <TextView
+                android:id="@+id/all_storage_description"
+                android:text="@string/storage_management_all_storage_descriptive_text"
+                style="@style/ManageSpaceActivityExplanationTextView" />
+
+            <Button
+                android:id="@+id/clear_all_data"
+                android:text="@string/storage_management_clear_all_data_button"
+                style="@style/ManageSpaceActivityButton" />
+        </LinearLayout>
+    </LinearLayout>
+</ScrollView>