chrome/android/java/res/layout/list_row_checked_icon.xml - Issue 1465363002: [Storage] Android - ManageSpace UI, Important Origins, and CBD Dialog

Side by Side Diff: chrome/android/java/res/layout/list_row_checked_icon.xml

Issue 1465363002: [Storage] Android - ManageSpace UI, Important Origins, and CBD Dialog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added row layout Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/android/java/AndroidManifest.xml ('k') | chrome/android/java/res/layout/manage_space_activity.xml » ('j') | chrome/android/java/res/layout/manage_space_activity.xml » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>
	Theresa 2016/05/12 20:22:41 Instead of making this a generic list row, I think Instead of making this a generic list row, I think a layout for the important sites makes sense. It's unlikely this exact configuration will be needed somewhere else w/ the exact same padding, etc. This file could be named confirm_important_sites_list_row.xml. Rather than a RelativeLayout it can be a horizontal LinearLayout. The ImageView will get specific width & height matching the favicon size, and the Checkbox will get layout_width="0dp" and layout_weight="1". data_reduction_stats_layout.xml has some good examples. dmurph 2016/05/13 23:46:22 Done. Show quoted text On 2016/05/12 at 20:22:41, Theresa Wellington wrote: > Instead of making this a generic list row, I think a layout for the important sites makes sense. It's unlikely this exact configuration will be needed somewhere else w/ the exact same padding, etc. > > This file could be named confirm_important_sites_list_row.xml. > > Rather than a RelativeLayout it can be a horizontal LinearLayout. The ImageView will get specific width & height matching the favicon size, and the Checkbox will get layout_width="0dp" and layout_weight="1". > > data_reduction_stats_layout.xml has some good examples. Done.
	2 <!-- Copyright 2016 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file. -->

	5

	6 <RelativeLayout

	7 xmlns:android="http://schemas.android.com/apk/res/android"

	8 android:layout_width="match_parent"

	9 android:layout_height="wrap_content"

	10 android:minHeight="?attr/listPreferredItemHeightSmall"

	11 android:padding="5dp">

	12 <CheckBox

	13 android:id="@+id/icon_row_checkbox"

	14 android:layout_width="wrap_content"

	15 android:layout_height="wrap_content"
	Theresa 2016/05/12 20:22:41 Should this height be match_parent so that it does Should this height be match_parent so that it doesn't wrap to two lines? Or does this screen allow wrapping? dmurph 2016/05/13 23:46:22 match_parent is fine. Show quoted text On 2016/05/12 at 20:22:41, Theresa Wellington wrote: > Should this height be match_parent so that it doesn't wrap to two lines? Or does this screen allow wrapping? match_parent is fine.
	16 android:layout_alignParentStart="true"

	17 android:layout_toStartOf="@+id/icon_row_image"

	18 android:textAppearance="?android:attr/textAppearanceMedium"

	19 android:layout_centerVertical="true"

	20 android:textColor="?attr/textColorAlertDialogListItem"/>

	21 <ImageView

	22 android:id="@+id/icon_row_image"

	23 android:layout_width="wrap_content"

	24 android:layout_height="wrap_content"
	Theresa 2016/05/12 20:22:41 I think this should be match_parent I think this should be match_parent dmurph 2016/05/13 23:46:22 done. Show quoted text On 2016/05/12 at 20:22:41, Theresa Wellington wrote: > I think this should be match_parent done.
	25 android:layout_alignParentEnd="true"

	26 android:layout_centerVertical="true"

	27 android:padding="5dp" />
	Theresa 2016/05/12 20:22:41 If the size of the icon doesn't exactly match the If the size of the icon doesn't exactly match the size of the ImageView, add android:scaleType="center" dmurph 2016/05/13 23:46:22 done. Show quoted text On 2016/05/12 at 20:22:41, Theresa Wellington wrote: > If the size of the icon doesn't exactly match the size of the ImageView, add android:scaleType="center" done.
	28 </RelativeLayout>

OLD	NEW