[Storage] Android - ManageSpace UI, Important Origins, and CBD Dialog

chrome/android/java/res/layout/select_dialog_listview.xml

Index: chrome/android/java/res/layout/select_dialog_listview.xml
diff --git a/chrome/android/java/res/layout/select_dialog_listview.xml b/chrome/android/java/res/layout/select_dialog_listview.xml
new file mode 100644
index 0000000000000000000000000000000000000000..ad2db4a1f4c139dbb55d119a2a01ef61f0bfa93b
--- /dev/null
+++ b/chrome/android/java/res/layout/select_dialog_listview.xml
@@ -0,0 +1,16 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!-- Copyright 2016 The Chromium Authors. All rights reserved.
+     Use of this source code is governed by a BSD-style license that can be
+     found in the LICENSE file. -->
+ 
+<!-- Based on device/apps/common/res/layout/select_dialog.xml -->

[Theresa, 2016/04/27 21:10:57]

Again, I think this comment is unnecessary. If it's exactly the same, could you
just use AlertDialog instead of declaring custom xml?

[dmurph, 2016/04/29 23:53:47]

It's the same but it's not haha. I'm using a list view here, instead of special
view class, and I can't use the AlertDialog built in list features as it doesn't
let me include a 'message' field then. Ugh android is annoying.

+<ListView xmlns:android="http://schemas.android.com/apk/res/android"
+    android:id="@id/select_dialog_listview"
+    android:layout_width="match_parent"
+    android:layout_height="match_parent"
+    android:layout_marginTop="5px"

[Theresa, 2016/04/27 21:10:57]

Use dp instead of px

[dmurph, 2016/04/29 23:53:47]

Done.

+    android:cacheColorHint="@null"

[Theresa, 2016/04/27 21:10:57]

Are you intending for the list background to be transparent?

[dmurph, 2016/04/29 23:53:47]

Copied. I'll remove.

+    android:divider="?android:attr/listDividerAlertDialog"
+    android:scrollbars="vertical"
+    android:overScrollMode="ifContentScrolls"
+    android:textAlignment="viewStart" />