chrome/android/java/res/layout/select_dialog_listview.xml - Issue 1465363002: [Storage] Android - ManageSpace UI, Important Origins, and CBD Dialog

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/select_dialog_listview.xml

Issue 1465363002: [Storage] Android - ManageSpace UI, Important Origins, and CBD Dialog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments, working Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/android/java/res/layout/manage_space_activity.xml ('K') | « chrome/android/java/res/layout/manage_space_activity.xml ('k') | chrome/android/java/res/layout/storage_preference_fragment.xml » ('j') | chrome/android/java/res/layout/storage_preference_fragment.xml » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- Copyright 2016 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file. -->

	5

	6 <!-- Based on device/apps/common/res/layout/select_dialog.xml -->
	Theresa 2016/04/27 21:10:57 Again, I think this comment is unnecessary. If it' Again, I think this comment is unnecessary. If it's exactly the same, could you just use AlertDialog instead of declaring custom xml? dmurph 2016/04/29 23:53:47 It's the same but it's not haha. I'm using a list Show quoted text On 2016/04/27 at 21:10:57, Theresa Wellington wrote: > Again, I think this comment is unnecessary. If it's exactly the same, could you just use AlertDialog instead of declaring custom xml? It's the same but it's not haha. I'm using a list view here, instead of special view class, and I can't use the AlertDialog built in list features as it doesn't let me include a 'message' field then. Ugh android is annoying.
	7 <ListView xmlns:android="http://schemas.android.com/apk/res/android"

	8 android:id="@id/select_dialog_listview"

	9 android:layout_width="match_parent"

	10 android:layout_height="match_parent"

	11 android:layout_marginTop="5px"
	Theresa 2016/04/27 21:10:57 Use dp instead of px Use dp instead of px dmurph 2016/04/29 23:53:47 Done. Show quoted text On 2016/04/27 at 21:10:57, Theresa Wellington wrote: > Use dp instead of px Done.
	12 android:cacheColorHint="@null"
	Theresa 2016/04/27 21:10:57 Are you intending for the list background to be tr Are you intending for the list background to be transparent? dmurph 2016/04/29 23:53:47 Copied. I'll remove. Show quoted text On 2016/04/27 at 21:10:57, Theresa Wellington wrote: > Are you intending for the list background to be transparent? Copied. I'll remove.
	13 android:divider="?android:attr/listDividerAlertDialog"

	14 android:scrollbars="vertical"

	15 android:overScrollMode="ifContentScrolls"

	16 android:textAlignment="viewStart" />

OLD	NEW