[Storage] Android - ManageSpace UI, Important Origins, and CBD Dialog

chrome/android/java/res/layout/manage_space_activity.xml

Index: chrome/android/java/res/layout/manage_space_activity.xml
diff --git a/chrome/android/java/res/layout/manage_space_activity.xml b/chrome/android/java/res/layout/manage_space_activity.xml
new file mode 100644
index 0000000000000000000000000000000000000000..870e90172355abb759364f9b4bf8248ce6b12a75
--- /dev/null
+++ b/chrome/android/java/res/layout/manage_space_activity.xml
@@ -0,0 +1,165 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!-- Copyright 2016 The Chromium Authors. All rights reserved.
+     Use of this source code is governed by a BSD-style license that can be
+     found in the LICENSE file. -->
+
+<!-- Based on Play Services' manage_space_activity.xml layout file. -->

[Theresa, 2016/04/27 21:10:57]

Play Service's xml file probably isn't public. I would leave this comment out.

[dmurph, 2016/04/29 23:53:47]

Done.

+<ScrollView
+    xmlns:android="http://schemas.android.com/apk/res/android"
+    android:id="@+id/main_scroll_view"
+    android:layout_width="match_parent"
+    android:layout_height="match_parent" >
+
+    <LinearLayout
+        android:id="@+id/main_view"
+        android:layout_width="match_parent"
+        android:layout_height="match_parent"
+        android:layout_marginStart="16dip"

[Theresa, 2016/04/27 21:10:57]

Our xml files use "dp" rather than "dip" (they're interchangeable)

[dmurph, 2016/04/29 23:53:47]

Done.

+        android:layout_marginEnd="16dip"
+        android:orientation="vertical"
+        android:paddingStart="6dip"
+        android:paddingEnd="6dip"
+        android:paddingTop="5dip"
+        android:paddingBottom="5dip">
+
+        <!-- ======== 'Unimportant Storage' Info ======== -->
+        <TextView
+            android:id="@+id/unimportant_site_data_description"
+            android:text="@string/storage_management_unimportant_site_data_descriptive_text"
+            android:textAppearance="?android:attr/textAppearanceMedium"
+            android:layout_height="wrap_content"
+            android:layout_width="match_parent"
+            android:paddingTop="6dip" />
+
+        <LinearLayout
+            android:layout_width="match_parent"
+            android:layout_height="wrap_content"
+            android:orientation="horizontal"
+            android:baselineAligned="true"
+            android:paddingTop="-1dip">

[Theresa, 2016/04/27 21:10:57]

Negative padding is odd. The field right below has +6dp.. can you make that +5dp
and drop this padding? Or just drop it all together?

[dmurph, 2016/04/29 23:53:47]

Done.

+
+            <TextView
+                android:id="@+id/unimportant_site_data_size_prefix"
+                android:text="@string/storage_management_unimportant_site_data_size_label"
+                android:textAppearance="?android:attr/textAppearanceMedium"
+                android:layout_height="wrap_content"
+                android:layout_width="wrap_content"
+                android:maxLines="1"
+                android:paddingTop="6dip" />
+
+            <ImageView
+                android:src="@drawable/dotted_line_480px"
+                android:layout_width="0dip"
+                android:layout_weight="1"
+                android:layout_height="1px"

[Theresa, 2016/04/27 21:10:57]

Is the dotted line only 1px on xxxhdpi devices as well? Or should this be 1dp?


I couldn't figure out how to comment on the image files directly, so some other
thoughts:
- including 480px in the file name is odd
- missing an asset for xxxhdpi
- make sure to run optimize-png-files.sh on the new png's
- can you you use a 1 dot + padding image & create an xml drawable w/ width
480dp android:tileMode set to repeat the dot rather than include a long dotted
line? Or maybe, given where this dotted line occurs, the drawable could fill in
all of the space between the text and MB instead of having a specific width.

[dmurph, 2016/04/29 23:53:47]

Ok, I'm looking into getting this right.

+                android:layout_gravity="bottom"
+                android:layout_marginStart="1dip"
+                android:layout_marginEnd="1dip"
+                android:layout_marginBottom="4dip"
+                android:scaleType="center" />
+
+            <TextView
+                android:id="@+id/unimportant_site_data_storage_size_text"
+                android:paddingTop="6dip"

[Theresa, 2016/04/27 21:10:57]

Define a style for the TextView's in this file since they share many parameters
(paddingTop, textAppearance, layout_height, and layout_width)

[dmurph, 2016/04/29 23:53:47]

Done.

+                android:textAppearance="?android:attr/textAppearanceMedium"
+                android:layout_height="wrap_content"
+                android:layout_width="wrap_content"
+                android:maxLines="1" />
+        </LinearLayout>
+
+        <Button
+            android:id="@+id/clear_unimportant_site_data_storage"
+            android:text="@string/storage_management_clear_unimportant_site_data_button"
+            android:layout_width="wrap_content"
+            android:layout_height="wrap_content"
+            android:layout_gravity="end"
+            android:layout_marginTop="8dp"
+            android:paddingStart="32dp"
+            android:paddingEnd="32dp" />
+
+
+        <!-- ======== Site Storage Info ======== -->
+        <TextView
+            android:id="@+id/site_data_description"
+            android:text="@string/storage_management_site_data_descriptive_text"
+            android:textAppearance="?android:attr/textAppearanceMedium"
+            android:layout_height="wrap_content"
+            android:layout_width="match_parent"
+            android:paddingTop="6dip" />
+
+        <LinearLayout
+            android:layout_width="match_parent"
+            android:layout_height="wrap_content"
+            android:orientation="horizontal"
+            android:baselineAligned="true"
+            android:paddingTop="-1dip">
+
+            <TextView
+                android:id="@+id/site_data_size_prefix"
+                android:text="@string/storage_management_site_data_size_label"
+                android:textAppearance="?android:attr/textAppearanceMedium"
+                android:layout_height="wrap_content"
+                android:layout_width="wrap_content"
+                android:maxLines="1"
+                android:paddingTop="6dip" />
+
+            <ImageView
+                android:src="@drawable/dotted_line_480px"
+                android:layout_width="0dip"
+                android:layout_weight="1"
+                android:layout_height="1px"
+                android:layout_gravity="bottom"
+                android:layout_marginStart="1dip"
+                android:layout_marginEnd="1dip"
+                android:layout_marginBottom="4dip"
+                android:scaleType="center" />
+
+            <TextView
+                android:id="@+id/site_data_storage_size_text"
+                android:paddingTop="6dip"
+                android:textAppearance="?android:attr/textAppearanceMedium"
+                android:layout_height="wrap_content"
+                android:layout_width="wrap_content"
+                android:maxLines="1" />
+        </LinearLayout>
+
+        <Button
+            android:id="@+id/manage_site_data_storage"
+            android:text="@string/storage_management_manage_site_data_button"
+            android:layout_width="wrap_content"
+            android:layout_height="wrap_content"
+            android:layout_gravity="end"
+            android:layout_marginTop="8dp"
+            android:paddingStart="32dp"
+            android:paddingEnd="32dp" />

[Theresa, 2016/04/27 21:10:57]

Declare a style for the buttons in this file to share.

[dmurph, 2016/04/29 23:53:47]

Done.

+
+        <!-- ======== Global storage info ======== -->
+        <LinearLayout
+            android:id="@+id/clear_all_data_section"
+            android:orientation="vertical"
+            android:layout_width="match_parent"
+            android:layout_height="wrap_content" >
+
+            <TextView
+                android:id="@+id/all_storage_description"
+                android:text="@string/storage_management_all_storage_descriptive_text"
+                android:textAppearance="?android:attr/textAppearanceMedium"
+                android:layout_height="wrap_content"
+                android:layout_width="match_parent"
+                android:paddingTop="18dip" />

[Theresa, 2016/04/27 21:10:57]

Why does this text view have so much padding compared to the others? Does it
make sense to move the padding to its parent LinearLayout?

[dmurph, 2016/04/29 23:53:47]

Done. It's for making it a little separate.

+
+            <Button
+                android:id="@+id/clear_all_data"
+                android:text="@string/storage_management_clear_all_data_button"
+                android:layout_width="wrap_content"
+                android:layout_height="wrap_content"
+                android:layout_gravity="end"
+                android:layout_marginTop="8dp"
+                android:paddingStart="32dp"
+                android:paddingEnd="32dp" />
+

[Finnur, 2016/04/27 13:49:15]

nit: Delete extra line (same below).

[dmurph, 2016/04/27 20:36:47]

Done.

+        </LinearLayout>
+
+    </LinearLayout>
+
+</ScrollView>