chrome/android/java/res/layout/manage_space_activity.xml - Issue 1465363002: [Storage] Android - ManageSpace UI, Important Origins, and CBD Dialog

Side by Side Diff: chrome/android/java/res/layout/manage_space_activity.xml

Issue 1465363002: [Storage] Android - ManageSpace UI, Important Origins, and CBD Dialog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments, working Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/android/java/AndroidManifest.xml ('K') | « chrome/android/java/res/drawable-xxhdpi/dotted_line_480px.png ('k') | chrome/android/java/res/layout/select_dialog_listview.xml » ('j') | chrome/android/java/res/layout/select_dialog_listview.xml » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- Copyright 2016 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file. -->

	5

	6 <!-- Based on Play Services' manage_space_activity.xml layout file. -->
	Theresa 2016/04/27 21:10:57 Play Service's xml file probably isn't public. I w Play Service's xml file probably isn't public. I would leave this comment out. dmurph 2016/04/29 23:53:47 Done. Show quoted text On 2016/04/27 at 21:10:57, Theresa Wellington wrote: > Play Service's xml file probably isn't public. I would leave this comment out. Done.
	7 <ScrollView

	8 xmlns:android="http://schemas.android.com/apk/res/android"

	9 android:id="@+id/main_scroll_view"

	10 android:layout_width="match_parent"

	11 android:layout_height="match_parent" >

	12

	13 <LinearLayout

	14 android:id="@+id/main_view"

	15 android:layout_width="match_parent"

	16 android:layout_height="match_parent"

	17 android:layout_marginStart="16dip"
	Theresa 2016/04/27 21:10:57 Our xml files use "dp" rather than "dip" (they're Our xml files use "dp" rather than "dip" (they're interchangeable) dmurph 2016/04/29 23:53:47 Done. Show quoted text On 2016/04/27 at 21:10:57, Theresa Wellington wrote: > Our xml files use "dp" rather than "dip" (they're interchangeable) Done.
	18 android:layout_marginEnd="16dip"

	19 android:orientation="vertical"

	20 android:paddingStart="6dip"

	21 android:paddingEnd="6dip"

	22 android:paddingTop="5dip"

	23 android:paddingBottom="5dip">

	24

	25 <!-- ======== 'Unimportant Storage' Info ======== -->

	26 <TextView

	27 android:id="@+id/unimportant_site_data_description"

	28 android:text="@string/storage_management_unimportant_site_data_descr iptive_text"

	29 android:textAppearance="?android:attr/textAppearanceMedium"

	30 android:layout_height="wrap_content"

	31 android:layout_width="match_parent"

	32 android:paddingTop="6dip" />

	33

	34 <LinearLayout

	35 android:layout_width="match_parent"

	36 android:layout_height="wrap_content"

	37 android:orientation="horizontal"

	38 android:baselineAligned="true"

	39 android:paddingTop="-1dip">
	Theresa 2016/04/27 21:10:57 Negative padding is odd. The field right below has Negative padding is odd. The field right below has +6dp.. can you make that +5dp and drop this padding? Or just drop it all together? dmurph 2016/04/29 23:53:47 Done. Show quoted text On 2016/04/27 at 21:10:57, Theresa Wellington wrote: > Negative padding is odd. The field right below has +6dp.. can you make that +5dp and drop this padding? Or just drop it all together? Done.
	40

	41 <TextView

	42 android:id="@+id/unimportant_site_data_size_prefix"

	43 android:text="@string/storage_management_unimportant_site_data_s ize_label"

	44 android:textAppearance="?android:attr/textAppearanceMedium"

	45 android:layout_height="wrap_content"

	46 android:layout_width="wrap_content"

	47 android:maxLines="1"

	48 android:paddingTop="6dip" />

	49

	50 <ImageView

	51 android:src="@drawable/dotted_line_480px"

	52 android:layout_width="0dip"

	53 android:layout_weight="1"

	54 android:layout_height="1px"
	Theresa 2016/04/27 21:10:57 Is the dotted line only 1px on xxxhdpi devices as Is the dotted line only 1px on xxxhdpi devices as well? Or should this be 1dp? I couldn't figure out how to comment on the image files directly, so some other thoughts: - including 480px in the file name is odd - missing an asset for xxxhdpi - make sure to run optimize-png-files.sh on the new png's - can you you use a 1 dot + padding image & create an xml drawable w/ width 480dp android:tileMode set to repeat the dot rather than include a long dotted line? Or maybe, given where this dotted line occurs, the drawable could fill in all of the space between the text and MB instead of having a specific width. dmurph 2016/04/29 23:53:47 Ok, I'm looking into getting this right. Show quoted text On 2016/04/27 at 21:10:57, Theresa Wellington wrote: > Is the dotted line only 1px on xxxhdpi devices as well? Or should this be 1dp? > > > I couldn't figure out how to comment on the image files directly, so some other thoughts: > - including 480px in the file name is odd > - missing an asset for xxxhdpi > - make sure to run optimize-png-files.sh on the new png's > - can you you use a 1 dot + padding image & create an xml drawable w/ width 480dp android:tileMode set to repeat the dot rather than include a long dotted line? Or maybe, given where this dotted line occurs, the drawable could fill in all of the space between the text and MB instead of having a specific width. Ok, I'm looking into getting this right.
	55 android:layout_gravity="bottom"

	56 android:layout_marginStart="1dip"

	57 android:layout_marginEnd="1dip"

	58 android:layout_marginBottom="4dip"

	59 android:scaleType="center" />

	60

	61 <TextView

	62 android:id="@+id/unimportant_site_data_storage_size_text"

	63 android:paddingTop="6dip"
	Theresa 2016/04/27 21:10:57 Define a style for the TextView's in this file sin Define a style for the TextView's in this file since they share many parameters (paddingTop, textAppearance, layout_height, and layout_width) dmurph 2016/04/29 23:53:47 Done. Show quoted text On 2016/04/27 at 21:10:57, Theresa Wellington wrote: > Define a style for the TextView's in this file since they share many parameters (paddingTop, textAppearance, layout_height, and layout_width) Done.
	64 android:textAppearance="?android:attr/textAppearanceMedium"

	65 android:layout_height="wrap_content"

	66 android:layout_width="wrap_content"

	67 android:maxLines="1" />

	68 </LinearLayout>

	69

	70 <Button

	71 android:id="@+id/clear_unimportant_site_data_storage"

	72 android:text="@string/storage_management_clear_unimportant_site_data _button"

	73 android:layout_width="wrap_content"

	74 android:layout_height="wrap_content"

	75 android:layout_gravity="end"

	76 android:layout_marginTop="8dp"

	77 android:paddingStart="32dp"

	78 android:paddingEnd="32dp" />

	79

	80

	81 <!-- ======== Site Storage Info ======== -->

	82 <TextView

	83 android:id="@+id/site_data_description"

	84 android:text="@string/storage_management_site_data_descriptive_text"

	85 android:textAppearance="?android:attr/textAppearanceMedium"

	86 android:layout_height="wrap_content"

	87 android:layout_width="match_parent"

	88 android:paddingTop="6dip" />

	89

	90 <LinearLayout

	91 android:layout_width="match_parent"

	92 android:layout_height="wrap_content"

	93 android:orientation="horizontal"

	94 android:baselineAligned="true"

	95 android:paddingTop="-1dip">

	96

	97 <TextView

	98 android:id="@+id/site_data_size_prefix"

	99 android:text="@string/storage_management_site_data_size_label"

	100 android:textAppearance="?android:attr/textAppearanceMedium"

	101 android:layout_height="wrap_content"

	102 android:layout_width="wrap_content"

	103 android:maxLines="1"

	104 android:paddingTop="6dip" />

	105

	106 <ImageView

	107 android:src="@drawable/dotted_line_480px"

	108 android:layout_width="0dip"

	109 android:layout_weight="1"

	110 android:layout_height="1px"

	111 android:layout_gravity="bottom"

	112 android:layout_marginStart="1dip"

	113 android:layout_marginEnd="1dip"

	114 android:layout_marginBottom="4dip"

	115 android:scaleType="center" />

	116

	117 <TextView

	118 android:id="@+id/site_data_storage_size_text"

	119 android:paddingTop="6dip"

	120 android:textAppearance="?android:attr/textAppearanceMedium"

	121 android:layout_height="wrap_content"

	122 android:layout_width="wrap_content"

	123 android:maxLines="1" />

	124 </LinearLayout>

	125

	126 <Button

	127 android:id="@+id/manage_site_data_storage"

	128 android:text="@string/storage_management_manage_site_data_button"

	129 android:layout_width="wrap_content"

	130 android:layout_height="wrap_content"

	131 android:layout_gravity="end"

	132 android:layout_marginTop="8dp"

	133 android:paddingStart="32dp"

	134 android:paddingEnd="32dp" />
	Theresa 2016/04/27 21:10:57 Declare a style for the buttons in this file to sh Declare a style for the buttons in this file to share. dmurph 2016/04/29 23:53:47 Done. Show quoted text On 2016/04/27 at 21:10:57, Theresa Wellington wrote: > Declare a style for the buttons in this file to share. Done.
	135

	136 <!-- ======== Global storage info ======== -->

	137 <LinearLayout

	138 android:id="@+id/clear_all_data_section"

	139 android:orientation="vertical"

	140 android:layout_width="match_parent"

	141 android:layout_height="wrap_content" >

	142

	143 <TextView

	144 android:id="@+id/all_storage_description"

	145 android:text="@string/storage_management_all_storage_descriptive _text"

	146 android:textAppearance="?android:attr/textAppearanceMedium"

	147 android:layout_height="wrap_content"

	148 android:layout_width="match_parent"

	149 android:paddingTop="18dip" />
	Theresa 2016/04/27 21:10:57 Why does this text view have so much padding compa Why does this text view have so much padding compared to the others? Does it make sense to move the padding to its parent LinearLayout? dmurph 2016/04/29 23:53:47 Done. It's for making it a little separate. Show quoted text On 2016/04/27 at 21:10:57, Theresa Wellington wrote: > Why does this text view have so much padding compared to the others? Does it make sense to move the padding to its parent LinearLayout? Done. It's for making it a little separate.
	150

	151 <Button

	152 android:id="@+id/clear_all_data"

	153 android:text="@string/storage_management_clear_all_data_button"

	154 android:layout_width="wrap_content"

	155 android:layout_height="wrap_content"

	156 android:layout_gravity="end"

	157 android:layout_marginTop="8dp"

	158 android:paddingStart="32dp"

	159 android:paddingEnd="32dp" />

	160
	Finnur 2016/04/27 13:49:15 nit: Delete extra line (same below). nit: Delete extra line (same below). dmurph 2016/04/27 20:36:47 Done. Show quoted text On 2016/04/27 at 13:49:15, Finnur wrote: > nit: Delete extra line (same below). Done.
	161 </LinearLayout>

	162

	163 </LinearLayout>

	164

	165 </ScrollView>

OLD	NEW