Check framebuffer texture attachments are cube complete

Check framebuffer texture attachments are cube complete

BUG=559362
TEST=conformance/textures/misc/cube-incomplete-fbo.html

Committed: https://crrev.com/699e4fdfe14d79d8938c4b20913cbe4ef3f58e64
Cr-Commit-Position: refs/heads/master@{#361397}

[qiankun, 2015-11-23 12:14:33]

qiankun.miao@intel.com changed reviewers:
+ bajones@chromium.org, kbr@chromium.org, zmo@chromium.org

[qiankun, 2015-11-23 12:14:34]

PTAL.

[zmo, 2015-11-23 19:40:37]

On 2015/11/23 12:14:34, qiankun wrote:
> PTAL.

LGTM, but should we do the same thing in command buffer also? (maybe in another
CL)

[zmo, 2015-11-23 19:40:44]

zmo@google.com changed reviewers:
+ zmo@google.com

[zmo, 2015-11-23 19:40:44]

https://codereview.chromium.org/1465173002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp (right):

https://codereview.chromium.org/1465173002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp:149: return false;
Maybe ASSERT_NOT_REACHED() here?

[Ken Russell (switch to Gerrit), 2015-11-24 00:37:03]

I defer to zmo's review.

https://codereview.chromium.org/1465173002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp (right):

https://codereview.chromium.org/1465173002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp:467: *reason
="attachment is not cube complete";
Add space after =.

[qiankun, 2015-11-24 03:57:08]

The CQ bit was checked by qiankun.miao@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2015-11-24 03:57:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1465173002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1465173002/20001

[commit-bot: I haz the power, 2015-11-24 03:57:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-24 03:57:55]

Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are
accepted.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[qiankun, 2015-11-24 04:11:43]

Thanks for review! It still needs an owner review to land.

https://codereview.chromium.org/1465173002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp (right):

https://codereview.chromium.org/1465173002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp:149: return false;
On 2015/11/23 19:40:44, zmo wrote:
> Maybe ASSERT_NOT_REACHED() here?

Done.

https://codereview.chromium.org/1465173002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp:467: *reason
="attachment is not cube complete";
On 2015/11/24 00:37:03, Ken Russell wrote:
> Add space after =.

Done.

[Zhenyao Mo, 2015-11-24 17:18:47]

LGTM

[Zhenyao Mo, 2015-11-24 17:18:52]

The CQ bit was checked by zmo@chromium.org

[Zhenyao Mo, 2015-11-24 17:18:52]

The patchset sent to the CQ was uploaded after l-g-t-m from zmo@google.com
Link to the patchset: https://codereview.chromium.org/1465173002/#ps20001
(title: "add assert_not_reached and add missing space")

[commit-bot: I haz the power, 2015-11-24 17:20:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1465173002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1465173002/20001

[commit-bot: I haz the power, 2015-11-24 18:39:16]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-24 18:40:23]

Patchset 2 (id:??) landed as
https://crrev.com/699e4fdfe14d79d8938c4b20913cbe4ef3f58e64
Cr-Commit-Position: refs/heads/master@{#361397}