Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1175)

Side by Side Diff: third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.h

Issue 1465173002: Check framebuffer texture attachments are cube complete (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add assert_not_reached and add missing space Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Apple Inc. All rights reserved. 2 * Copyright (C) 2009 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 virtual ~WebGLAttachment(); 42 virtual ~WebGLAttachment();
43 43
44 virtual GLsizei width() const = 0; 44 virtual GLsizei width() const = 0;
45 virtual GLsizei height() const = 0; 45 virtual GLsizei height() const = 0;
46 virtual GLenum format() const = 0; 46 virtual GLenum format() const = 0;
47 // For texture attachment, type() returns the type of the attached textu re. 47 // For texture attachment, type() returns the type of the attached textu re.
48 // For renderbuffer attachment, the type of the renderbuffer may vary wi th GL implementation. 48 // For renderbuffer attachment, the type of the renderbuffer may vary wi th GL implementation.
49 // To avoid confusion, it would be better to not implement type() for re nderbuffer attachment and 49 // To avoid confusion, it would be better to not implement type() for re nderbuffer attachment and
50 // we should always use the internalformat of the renderbuffer and avoid using type() API. 50 // we should always use the internalformat of the renderbuffer and avoid using type() API.
51 virtual GLenum type() const = 0; 51 virtual GLenum type() const = 0;
52 virtual bool isCubeComplete() const = 0;
52 virtual WebGLSharedObject* object() const = 0; 53 virtual WebGLSharedObject* object() const = 0;
53 virtual bool isSharedObject(WebGLSharedObject*) const = 0; 54 virtual bool isSharedObject(WebGLSharedObject*) const = 0;
54 virtual bool valid() const = 0; 55 virtual bool valid() const = 0;
55 virtual void onDetached(WebGraphicsContext3D*) = 0; 56 virtual void onDetached(WebGraphicsContext3D*) = 0;
56 virtual void attach(WebGraphicsContext3D*, GLenum target, GLenum attachm ent) = 0; 57 virtual void attach(WebGraphicsContext3D*, GLenum target, GLenum attachm ent) = 0;
57 virtual void unattach(WebGraphicsContext3D*, GLenum target, GLenum attac hment) = 0; 58 virtual void unattach(WebGraphicsContext3D*, GLenum target, GLenum attac hment) = 0;
58 59
59 DEFINE_INLINE_VIRTUAL_TRACE() { } 60 DEFINE_INLINE_VIRTUAL_TRACE() { }
60 61
61 protected: 62 protected:
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
141 142
142 Vector<GLenum> m_drawBuffers; 143 Vector<GLenum> m_drawBuffers;
143 Vector<GLenum> m_filteredDrawBuffers; 144 Vector<GLenum> m_filteredDrawBuffers;
144 145
145 GLenum m_readBuffer; 146 GLenum m_readBuffer;
146 }; 147 };
147 148
148 } // namespace blink 149 } // namespace blink
149 150
150 #endif // WebGLFramebuffer_h 151 #endif // WebGLFramebuffer_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698