third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.h - Issue 1465173002: Check framebuffer texture attachments are cube complete

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.h

Issue 1465173002: Check framebuffer texture attachments are cube complete (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add assert_not_reached and add missing space Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.h

diff --git a/third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.h b/third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.h

index 6522650c51837a1c1f5892113bbbf32f25a53372..1b61c5d47b07edb10ed973331f6be0356efc5968 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.h

+++ b/third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.h

@@ -49,6 +49,7 @@ public:

// To avoid confusion, it would be better to not implement type() for renderbuffer attachment and

// we should always use the internalformat of the renderbuffer and avoid using type() API.

virtual GLenum type() const = 0;

+ virtual bool isCubeComplete() const = 0;

virtual WebGLSharedObject* object() const = 0;

virtual bool isSharedObject(WebGLSharedObject*) const = 0;

virtual bool valid() const = 0;

« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp » ('j') | no next file with comments »