|
|
Created:
5 years, 2 months ago by Mariusz Mlynski Modified:
5 years, 1 month ago Reviewers:
kouhei (in TOK) CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDefer widget updates in ContainerNode::parserRemoveChild.
ContainerNode::parserRemoveChild is the only consumer of ContainerNode::removeBetween that doesn't defer widget updates during the call. This could potentially lead to problems with scripts running at an inopportune time.
This patch adds a RAII guard that runs deferred widget updates at the end of parserRemoveChild.
BUG=560011
Committed: https://crrev.com/05926d6f4e749cd49a16fa04a35e3498eb1b01a0
Cr-Commit-Position: refs/heads/master@{#363154}
Patch Set 1 #
Messages
Total messages: 17 (7 generated)
kouhei@chromium.org changed reviewers: + kouhei@chromium.org
code change looks good. Before committing the change, would you sign our CLA at https://cla.developers.google.com/about/google-individual ? Also, please submit a CL to add yourself to AUTHORS file.
On 2015/12/03 03:10:14, kouhei wrote: > code change looks good. > > Before committing the change, would you sign our CLA at > https://cla.developers.google.com/about/google-individual ? > Also, please submit a CL to add yourself to AUTHORS file. Both already done. Thanks for the review!
The CQ bit was checked by kouhei@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1464223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1464223002/1
On 2015/12/03 03:12:47, Mariusz Mlynski wrote: > On 2015/12/03 03:10:14, kouhei wrote: > > code change looks good. > > > > Before committing the change, would you sign our CLA at > > https://cla.developers.google.com/about/google-individual ? > > Also, please submit a CL to add yourself to AUTHORS file. > > Both already done. Thanks for the review! Thanks! lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by kouhei@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1464223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1464223002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by kouhei@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1464223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1464223002/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Defer widget updates in ContainerNode::parserRemoveChild. ContainerNode::parserRemoveChild is the only consumer of ContainerNode::removeBetween that doesn't defer widget updates during the call. This could potentially lead to problems with scripts running at an inopportune time. This patch adds a RAII guard that runs deferred widget updates at the end of parserRemoveChild. BUG=560011 ========== to ========== Defer widget updates in ContainerNode::parserRemoveChild. ContainerNode::parserRemoveChild is the only consumer of ContainerNode::removeBetween that doesn't defer widget updates during the call. This could potentially lead to problems with scripts running at an inopportune time. This patch adds a RAII guard that runs deferred widget updates at the end of parserRemoveChild. BUG=560011 Committed: https://crrev.com/05926d6f4e749cd49a16fa04a35e3498eb1b01a0 Cr-Commit-Position: refs/heads/master@{#363154} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/05926d6f4e749cd49a16fa04a35e3498eb1b01a0 Cr-Commit-Position: refs/heads/master@{#363154} |