Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: third_party/WebKit/Source/core/dom/ContainerNode.cpp

Issue 1464223002: Defer widget updates in ContainerNode::parserRemoveChild. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2013 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2013 Apple Inc. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 620 matching lines...) Expand 10 before | Expand all | Expand 10 after
631 // This may cause arbitrary Javascript execution via onunload handlers. 631 // This may cause arbitrary Javascript execution via onunload handlers.
632 if (oldChild.connectedSubframeCount()) 632 if (oldChild.connectedSubframeCount())
633 ChildFrameDisconnector(oldChild).disconnect(); 633 ChildFrameDisconnector(oldChild).disconnect();
634 634
635 if (oldChild.parentNode() != this) 635 if (oldChild.parentNode() != this)
636 return; 636 return;
637 637
638 ChildListMutationScope(*this).willRemoveChild(oldChild); 638 ChildListMutationScope(*this).willRemoveChild(oldChild);
639 oldChild.notifyMutationObserversNodeWillDetach(); 639 oldChild.notifyMutationObserversNodeWillDetach();
640 640
641 HTMLFrameOwnerElement::UpdateSuspendScope suspendWidgetHierarchyUpdates;
641 Node* prev = oldChild.previousSibling(); 642 Node* prev = oldChild.previousSibling();
642 Node* next = oldChild.nextSibling(); 643 Node* next = oldChild.nextSibling();
643 removeBetween(prev, next, oldChild); 644 removeBetween(prev, next, oldChild);
644 645
645 notifyNodeRemoved(oldChild); 646 notifyNodeRemoved(oldChild);
646 childrenChanged(ChildrenChange::forRemoval(oldChild, prev, next, ChildrenCha ngeSourceParser)); 647 childrenChanged(ChildrenChange::forRemoval(oldChild, prev, next, ChildrenCha ngeSourceParser));
647 } 648 }
648 649
649 // This differs from other remove functions because it forcibly removes all the children, 650 // This differs from other remove functions because it forcibly removes all the children,
650 // regardless of read-only status or event exceptions, e.g. 651 // regardless of read-only status or event exceptions, e.g.
(...skipping 876 matching lines...) Expand 10 before | Expand all | Expand 10 after
1527 return true; 1528 return true;
1528 1529
1529 if (node->isElementNode() && toElement(node)->shadow()) 1530 if (node->isElementNode() && toElement(node)->shadow())
1530 return true; 1531 return true;
1531 1532
1532 return false; 1533 return false;
1533 } 1534 }
1534 #endif 1535 #endif
1535 1536
1536 } // namespace blink 1537 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698