Defer widget updates in ContainerNode::parserRemoveChild.

Defer widget updates in ContainerNode::parserRemoveChild.

ContainerNode::parserRemoveChild is the only consumer of ContainerNode::removeBetween that doesn't defer widget updates during the call. This could potentially lead to problems with scripts running at an inopportune time.

This patch adds a RAII guard that runs deferred widget updates at the end of parserRemoveChild.

BUG=560011
Committed: https://crrev.com/05926d6f4e749cd49a16fa04a35e3498eb1b01a0
Cr-Commit-Position: refs/heads/master@{#363154}

[kouhei (in TOK), 2015-12-03 03:10:14]

kouhei@chromium.org changed reviewers:
+ kouhei@chromium.org

[kouhei (in TOK), 2015-12-03 03:10:14]

code change looks good.

Before committing the change, would you sign our CLA at
https://cla.developers.google.com/about/google-individual ?
Also, please submit a CL to add yourself to AUTHORS file.

[Mariusz Mlynski, 2015-12-03 03:12:47]

On 2015/12/03 03:10:14, kouhei wrote:
> code change looks good.
> 
> Before committing the change, would you sign our CLA at
> https://cla.developers.google.com/about/google-individual ?
> Also, please submit a CL to add yourself to AUTHORS file.

Both already done. Thanks for the review!

[kouhei (in TOK), 2015-12-03 03:13:44]

The CQ bit was checked by kouhei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-03 03:14:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1464223002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1464223002/1

[kouhei (in TOK), 2015-12-03 04:17:07]

On 2015/12/03 03:12:47, Mariusz Mlynski wrote:
> On 2015/12/03 03:10:14, kouhei wrote:
> > code change looks good.
> > 
> > Before committing the change, would you sign our CLA at
> > https://cla.developers.google.com/about/google-individual ?
> > Also, please submit a CL to add yourself to AUTHORS file.
> 
> Both already done. Thanks for the review!

Thanks! lgtm

[commit-bot: I haz the power, 2015-12-03 05:37:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-03 05:37:59]

Dry run: This issue passed the CQ dry run.

[kouhei (in TOK), 2015-12-03 23:19:26]

The CQ bit was checked by kouhei@chromium.org

[commit-bot: I haz the power, 2015-12-03 23:21:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1464223002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1464223002/1

[commit-bot: I haz the power, 2015-12-04 01:28:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-04 01:28:14]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)

[kouhei (in TOK), 2015-12-04 04:13:12]

The CQ bit was checked by kouhei@chromium.org

[commit-bot: I haz the power, 2015-12-04 04:13:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1464223002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1464223002/1

[commit-bot: I haz the power, 2015-12-04 06:45:26]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-12-04 06:46:38]

Description was changed from

==========
Defer widget updates in ContainerNode::parserRemoveChild.

ContainerNode::parserRemoveChild is the only consumer of
ContainerNode::removeBetween that doesn't defer widget updates during the call.
This could potentially lead to problems with scripts running at an inopportune
time.

This patch adds a RAII guard that runs deferred widget updates at the end of
parserRemoveChild.

BUG=560011
==========

to

==========
Defer widget updates in ContainerNode::parserRemoveChild.

ContainerNode::parserRemoveChild is the only consumer of
ContainerNode::removeBetween that doesn't defer widget updates during the call.
This could potentially lead to problems with scripts running at an inopportune
time.

This patch adds a RAII guard that runs deferred widget updates at the end of
parserRemoveChild.

BUG=560011

Committed: https://crrev.com/05926d6f4e749cd49a16fa04a35e3498eb1b01a0
Cr-Commit-Position: refs/heads/master@{#363154}
==========

[commit-bot: I haz the power, 2015-12-04 06:46:39]

Patchset 1 (id:??) landed as
https://crrev.com/05926d6f4e749cd49a16fa04a35e3498eb1b01a0
Cr-Commit-Position: refs/heads/master@{#363154}