Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1471583002: Add WritePushPromise() method in QuicHeadersStream for server push. (Closed)

Created:
5 years, 1 month ago by ianswett
Modified:
5 years ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@107697347
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add WritePushPromise() method in QuicHeadersStream for server push. Merge internal change: 107699435 R=rch@chromium.org BUG=

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -10 lines) Patch
M net/quic/quic_connection_test.cc View 1 chunk +1 line, -1 line 2 comments Download
M net/quic/quic_headers_stream.h View 1 chunk +9 lines, -1 line 0 comments Download
M net/quic/quic_headers_stream.cc View 2 chunks +30 lines, -7 lines 0 comments Download
M net/quic/quic_headers_stream_test.cc View 5 chunks +38 lines, -1 line 0 comments Download

Depends on Patchset:

Issue 1466153002 Patch 1

Dependent Patchsets:

Issue 1464153002 Patch 1

Messages

Total messages: 4 (0 generated)
ianswett
5 years, 1 month ago (2015-11-21 22:13:26 UTC) #1
Ryan Hamilton
lgtm https://codereview.chromium.org/1471583002/diff/1/net/quic/quic_connection_test.cc File net/quic/quic_connection_test.cc (right): https://codereview.chromium.org/1471583002/diff/1/net/quic/quic_connection_test.cc#newcode5252 net/quic/quic_connection_test.cc:5252: TEST_P(QuicConnectionTest, DISABLED_ReevaluateTimeUntilSendOnAck) { This does not appear to ...
5 years, 1 month ago (2015-11-21 22:19:00 UTC) #2
ianswett
Done in the Final branch. https://codereview.chromium.org/1471583002/diff/1/net/quic/quic_connection_test.cc File net/quic/quic_connection_test.cc (right): https://codereview.chromium.org/1471583002/diff/1/net/quic/quic_connection_test.cc#newcode5252 net/quic/quic_connection_test.cc:5252: TEST_P(QuicConnectionTest, DISABLED_ReevaluateTimeUntilSendOnAck) { On ...
5 years, 1 month ago (2015-11-23 20:03:15 UTC) #3
Ryan Hamilton
5 years, 1 month ago (2015-11-23 20:54:39 UTC) #4 
On 2015/11/23 20:03:15, ianswett wrote:
> Done in the Final branch.
> 
>
https://codereview.chromium.org/1471583002/diff/1/net/quic/quic_connection_te...
> File net/quic/quic_connection_test.cc (right):
> 
>
https://codereview.chromium.org/1471583002/diff/1/net/quic/quic_connection_te...
> net/quic/quic_connection_test.cc:5252: TEST_P(QuicConnectionTest,
> DISABLED_ReevaluateTimeUntilSendOnAck) {
> On 2015/11/21 22:19:00, Ryan Hamilton wrote:
> > This does not appear to be part of the original CL. What's the story here?
> 
> Done.

I'll lgtm this here, but I dont' understand why a change to QuicHeadersStream
could have possibly changed the expectations in QuicConnectionTest. I think
something else must be going on.

Powered by Google App Engine
This is Rietveld 408576698