Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1463793002: Simplify ImageResource::canRender() (Closed)

Created:
5 years, 1 month ago by davve
Modified:
5 years, 1 month ago
Reviewers:
f(malita), fs
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, dshwang, eae+blinkwatch, gavinp+loader_chromium.org, Nate Chapin, jchaffraix+rendering, leviw+renderwatch, loading-reviews+fetch_chromium.org, pdr+renderingwatchlist_chromium.org, rwlbuis, slimming-paint-reviews_chromium.org, szager+layoutwatch_chromium.org, tyoshino+watch_chromium.org, Yoav Weiss, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify ImageResource::canRender() Assume that neither image rotation nor scale can affect the image size emptiness. This makes it easier to further simplify imageSizeForLayoutObject later. BUG=559131 Committed: https://crrev.com/fec9b1244e99826e0c070c320d1babf09630bbc1 Cr-Commit-Position: refs/heads/master@{#361025}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -22 lines) Patch
M third_party/WebKit/Source/core/css/CSSCrossfadeValue.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ImageResource.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/BoxPainter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/InlineFlowBoxPainter.cpp View 3 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/paint/NinePieceImagePainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/StyleFetchedImage.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/StyleFetchedImage.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleFetchedImageSet.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/StyleFetchedImageSet.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleImage.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1463793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1463793002/1
5 years, 1 month ago (2015-11-20 14:04:50 UTC) #2
davve
PTAL. I was hoping to get to imageSizeForLayoutObject and pass RespectImageOrientationEnum instead of LayoutObject to ...
5 years, 1 month ago (2015-11-20 14:06:10 UTC) #4
fs
lgtm
5 years, 1 month ago (2015-11-20 14:15:21 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/143842)
5 years, 1 month ago (2015-11-20 20:07:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1463793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1463793002/1
5 years, 1 month ago (2015-11-21 15:31:46 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-21 17:20:02 UTC) #10
commit-bot: I haz the power
Failed to apply the patch.
5 years, 1 month ago (2015-11-21 17:20:28 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-11-21 17:21:00 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/fec9b1244e99826e0c070c320d1babf09630bbc1
Cr-Commit-Position: refs/heads/master@{#361025}

Powered by Google App Engine
This is Rietveld 408576698