Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Side by Side Diff: third_party/WebKit/Source/core/style/StyleImage.h

Issue 1463793002: Simplify ImageResource::canRender() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/style/StyleFetchedImageSet.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
3 * (C) 2000 Antti Koivisto (koivisto@kde.org) 3 * (C) 2000 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2003, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 5 * Copyright (C) 2003, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 virtual ~StyleImage() { } 46 virtual ~StyleImage() { }
47 47
48 bool operator==(const StyleImage& other) const 48 bool operator==(const StyleImage& other) const
49 { 49 {
50 return data() == other.data(); 50 return data() == other.data();
51 } 51 }
52 52
53 virtual PassRefPtrWillBeRawPtr<CSSValue> cssValue() const = 0; 53 virtual PassRefPtrWillBeRawPtr<CSSValue> cssValue() const = 0;
54 virtual PassRefPtrWillBeRawPtr<CSSValue> computedCSSValue() const = 0; 54 virtual PassRefPtrWillBeRawPtr<CSSValue> computedCSSValue() const = 0;
55 55
56 virtual bool canRender(const LayoutObject&, float /*multiplier*/) const { re turn true; } 56 virtual bool canRender() const { return true; }
57 virtual bool isLoaded() const { return true; } 57 virtual bool isLoaded() const { return true; }
58 virtual bool errorOccurred() const { return false; } 58 virtual bool errorOccurred() const { return false; }
59 virtual LayoutSize imageSize(const LayoutObject*, float multiplier) const = 0; 59 virtual LayoutSize imageSize(const LayoutObject*, float multiplier) const = 0;
60 virtual void computeIntrinsicDimensions(const LayoutObject*, Length& intrins icWidth, Length& intrinsicHeight, FloatSize& intrinsicRatio) = 0; 60 virtual void computeIntrinsicDimensions(const LayoutObject*, Length& intrins icWidth, Length& intrinsicHeight, FloatSize& intrinsicRatio) = 0;
61 virtual bool imageHasRelativeWidth() const = 0; 61 virtual bool imageHasRelativeWidth() const = 0;
62 virtual bool imageHasRelativeHeight() const = 0; 62 virtual bool imageHasRelativeHeight() const = 0;
63 virtual bool usesImageContainerSize() const = 0; 63 virtual bool usesImageContainerSize() const = 0;
64 virtual void addClient(LayoutObject*) = 0; 64 virtual void addClient(LayoutObject*) = 0;
65 virtual void removeClient(LayoutObject*) = 0; 65 virtual void removeClient(LayoutObject*) = 0;
66 virtual PassRefPtr<Image> image(const LayoutObject*, const IntSize&, float) const = 0; 66 virtual PassRefPtr<Image> image(const LayoutObject*, const IntSize&, float) const = 0;
(...skipping 23 matching lines...) Expand all
90 bool m_isImageResourceSet:1; 90 bool m_isImageResourceSet:1;
91 }; 91 };
92 92
93 #define DEFINE_STYLE_IMAGE_TYPE_CASTS(thisType, function) \ 93 #define DEFINE_STYLE_IMAGE_TYPE_CASTS(thisType, function) \
94 DEFINE_TYPE_CASTS(thisType, StyleImage, styleImage, styleImage->function, st yleImage.function); \ 94 DEFINE_TYPE_CASTS(thisType, StyleImage, styleImage, styleImage->function, st yleImage.function); \
95 inline thisType* to##thisType(const RefPtrWillBeMember<StyleImage>& styleIma ge) { return to##thisType(styleImage.get()); } \ 95 inline thisType* to##thisType(const RefPtrWillBeMember<StyleImage>& styleIma ge) { return to##thisType(styleImage.get()); } \
96 typedef int NeedsSemiColonAfterDefineStyleImageTypeCasts 96 typedef int NeedsSemiColonAfterDefineStyleImageTypeCasts
97 97
98 } 98 }
99 #endif 99 #endif
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/style/StyleFetchedImageSet.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698