third_party/WebKit/Source/core/layout/LayoutBox.cpp - Issue 1463793002: Simplify ImageResource::canRender()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.cpp

Issue 1463793002: Simplify ImageResource::canRender() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutBox.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.cpp b/third_party/WebKit/Source/core/layout/LayoutBox.cpp

index 84aa10f84b939bc45bb627dba3a3e49c75a9c3bf..4a4f729789e74e74629b83a48ea724f4c655a1f7 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBox.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutBox.cpp

@@ -4762,7 +4762,7 @@ inline bool LayoutBox::mustInvalidateFillLayersPaintOnWidthChange(const FillLaye

// Make sure we have a valid image.

StyleImage* img = layer.image();

- if (!img || !img->canRender(*this, style()->effectiveZoom()))

+ if (!img || !img->canRender())

return false;

if (layer.repeatX() != RepeatFill && layer.repeatX() != NoRepeatFill)

@@ -4837,7 +4837,7 @@ bool LayoutBox::canRenderBorderImage() const

return false;

StyleImage* borderImage = style()->borderImage().image();

- return borderImage && borderImage->canRender(*this, style()->effectiveZoom()) && borderImage->isLoaded();

+ return borderImage && borderImage->canRender() && borderImage->isLoaded();

}

ShapeOutsideInfo* LayoutBox::shapeOutsideInfo() const