gpu: Update translated shader source after link.

gpu: Refresh translated shader source every query.

ANGLE generates additional shader debug info during program linking.
We would miss this with the current method of caching the extended
translated source. Handle this by refreshing the translated source
after the link operation.

Unfortunately this only currently works with the GPU program cache
disabled, since we don't have the translated source attached to
the shader binaries. Use the --disable-gpu-program-cache flag to
get to the extended info.

BUG=angleproject:1179
R=kbr@chromium.org

Committed: https://crrev.com/f38c734f5dd3808cee8b17350f0f22ffa555c055
Cr-Commit-Position: refs/heads/master@{#360977}

[Jamie Madill, 2015-11-20 19:35:36]

Description was changed from

==========
gpu: Refresh translated shader source every query.

ANGLE generates additional shader debug info during program linking.
We would miss this with the current method of caching the extended
translated source. Handle this by refreshing the translated source
every time the query method is called.

Unfortunately this only currently works with the GPU program cache
disabled, since we don't have the translated source attached to
the shader binaries. Use the --disable-gpu-program-cache flag to
get to the extended info.

BUG=angleproject:1179
R=kbr@chromium.org
==========

to

==========
gpu: Refresh translated shader source every query.

ANGLE generates additional shader debug info during program linking.
We would miss this with the current method of caching the extended
translated source. Handle this by refreshing the translated source
every time the query method is called.

Unfortunately this only currently works with the GPU program cache
disabled, since we don't have the translated source attached to
the shader binaries. Use the --disable-gpu-program-cache flag to
get to the extended info.

BUG=angleproject:1179
R=kbr@chromium.org
==========

[Jamie Madill, 2015-11-20 19:35:36]

jmadill@chromium.org changed reviewers:
+ bajones@chromium.org, zmo@chromium.org
- kbr@chromium.org

[Jamie Madill, 2015-11-20 19:36:12]

PTAL, let me know if this is acceptable. This is an interim step to allow devs
to get access to more shader info. We can do better by enabling the info without
the extended flag, but it's not trivial.

[zmo, 2015-11-20 19:51:42]

On 2015/11/20 19:36:12, Jamie Madill wrote:
> PTAL, let me know if this is acceptable. This is an interim step to allow devs
> to get access to more shader info. We can do better by enabling the info
without
> the extended flag, but it's not trivial.

Per offline discussion with jmadill, we will update the translated shader source
after each link.

Two questions:

1) do we still want to expose translated shader source after compile (and before
link)? knowing that it won't be the actual shader source passing down to the
driver?

2) on an unsuccessful link, will the translated shader source still be updated
by ANGLE? If yes, we should still expose them, for debugging purpose.

[Jamie Madill, 2015-11-20 22:12:26]

On 2015/11/20 19:51:42, zmo wrote:
> On 2015/11/20 19:36:12, Jamie Madill wrote:
> > PTAL, let me know if this is acceptable. This is an interim step to allow
devs
> > to get access to more shader info. We can do better by enabling the info
> without
> > the extended flag, but it's not trivial.
> 
> Per offline discussion with jmadill, we will update the translated shader
source
> after each link.

done, PTAL.

> Two questions:
> 
> 1) do we still want to expose translated shader source after compile (and
before
> link)? knowing that it won't be the actual shader source passing down to the
> driver?

In the long term, it might be better to expose a new extension to query program
level translated sources. What do you think? I'm fine with whatever.

> 2) on an unsuccessful link, will the translated shader source still be updated
> by ANGLE? If yes, we should still expose them, for debugging purpose.

I decided to not update the sources, since ANGLE won't record them unless the
link is successful.

[zmo, 2015-11-20 23:57:43]

zmo@google.com changed reviewers:
+ zmo@google.com

[zmo, 2015-11-20 23:57:44]

LGTM

[Jamie Madill, 2015-11-21 00:14:05]

Thanks Mo - but can you re-LGTM with your @chromium, so I can pass OWNERS?

[bajones, 2015-11-21 00:14:40]

On 2015/11/21 00:14:05, Jamie Madill wrote:
> Thanks Mo - but can you re-LGTM with your @chromium, so I can pass OWNERS?

RS LGTM to unblock OWNERS.

[Jamie Madill, 2015-11-21 00:16:13]

The CQ bit was checked by jmadill@chromium.org

[Ken Russell (switch to Gerrit), 2015-11-21 00:16:42]

kbr@chromium.org changed reviewers:
+ kbr@chromium.org

[Ken Russell (switch to Gerrit), 2015-11-21 00:16:42]

Thanks for picking this up. LGTM

[commit-bot: I haz the power, 2015-11-21 00:17:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1463673004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1463673004/20001

[Jamie Madill, 2015-11-21 00:18:14]

Description was changed from

==========
gpu: Refresh translated shader source every query.

ANGLE generates additional shader debug info during program linking.
We would miss this with the current method of caching the extended
translated source. Handle this by refreshing the translated source
every time the query method is called.

Unfortunately this only currently works with the GPU program cache
disabled, since we don't have the translated source attached to
the shader binaries. Use the --disable-gpu-program-cache flag to
get to the extended info.

BUG=angleproject:1179
R=kbr@chromium.org
==========

to

==========
gpu: Refresh translated shader source every query.

ANGLE generates additional shader debug info during program linking.
We would miss this with the current method of caching the extended
translated source. Handle this by refreshing the translated source
after the link operation.

Unfortunately this only currently works with the GPU program cache
disabled, since we don't have the translated source attached to
the shader binaries. Use the --disable-gpu-program-cache flag to
get to the extended info.

BUG=angleproject:1179
R=kbr@chromium.org
==========

[commit-bot: I haz the power, 2015-11-21 01:26:11]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-21 01:26:54]

Patchset 2 (id:??) landed as
https://crrev.com/f38c734f5dd3808cee8b17350f0f22ffa555c055
Cr-Commit-Position: refs/heads/master@{#360977}