content/browser/renderer_host/render_widget_host_view_mac.mm - Issue 1463153002: Don't route a non-frame widget's keyboard event to main frame widget.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_mac.mm

Issue 1463153002: Don't route a non-frame widget's keyboard event to main frame widget. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Charlie's comments Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_aura.cc ('k') | content/browser/web_contents/web_contents_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_mac.mm

diff --git a/content/browser/renderer_host/render_widget_host_view_mac.mm b/content/browser/renderer_host/render_widget_host_view_mac.mm

index ff472ce4e1ce655867f83df3d204b6eb4fac2bb0..c4a1562001dfa933470eeac8043d803323f8d742 100644

--- a/content/browser/renderer_host/render_widget_host_view_mac.mm

+++ b/content/browser/renderer_host/render_widget_host_view_mac.mm

@@ -2104,12 +2104,8 @@ void RenderWidgetHostViewMac::OnDisplayMetricsChanged(

// If there are multiple widgets on the page (such as when there are

// out-of-process iframes), pick the one that should process this event.

- if (widgetHost->delegate()) {

- RenderWidgetHostImpl* focusedHost =

- widgetHost->delegate()->GetFocusedRenderWidgetHost();

- if (focusedHost)

- widgetHost = focusedHost;

- }

+ if (widgetHost->delegate())

+ widgetHost = widgetHost->delegate()->GetFocusedRenderWidgetHost(widgetHost);

// Suppress the escape key up event if necessary.

if (event.windowsKeyCode == ui::VKEY_ESCAPE && suppressNextEscapeKeyUp_) {

« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_aura.cc ('k') | content/browser/web_contents/web_contents_impl.h » ('j') | no next file with comments »