content/browser/renderer_host/render_widget_host_view_aura.cc - Issue 1463153002: Don't route a non-frame widget's keyboard event to main frame widget.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_aura.cc

Issue 1463153002: Don't route a non-frame widget's keyboard event to main frame widget. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Charlie's comments Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_android.cc ('k') | content/browser/renderer_host/render_widget_host_view_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_aura.cc

diff --git a/content/browser/renderer_host/render_widget_host_view_aura.cc b/content/browser/renderer_host/render_widget_host_view_aura.cc

index b62519e70c061ec85b46ff49b3d25d0772156c7f..3f7b0f1711a1fba7b810022c583969e3999a6a95 100644

--- a/content/browser/renderer_host/render_widget_host_view_aura.cc

+++ b/content/browser/renderer_host/render_widget_host_view_aura.cc

@@ -2771,12 +2771,8 @@ void RenderWidgetHostViewAura::ForwardKeyboardEvent(

// If there are multiple widgets on the page (such as when there are

// out-of-process iframes), pick the one that should process this event.

- if (host_->delegate()) {

- RenderWidgetHostImpl* focused_host =

- host_->delegate()->GetFocusedRenderWidgetHost();

- if (focused_host)

- target_host = focused_host;

- }

+ if (host_->delegate())

+ target_host = host_->delegate()->GetFocusedRenderWidgetHost(host_);

#if defined(OS_LINUX) && !defined(OS_CHROMEOS)

ui::TextEditKeyBindingsDelegateAuraLinux* keybinding_delegate =