content/browser/web_contents/web_contents_impl.h - Issue 1463153002: Don't route a non-frame widget's keyboard event to main frame widget.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.h

Issue 1463153002: Don't route a non-frame widget's keyboard event to main frame widget. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Charlie's comments Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_mac.mm ('k') | content/browser/web_contents/web_contents_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/web_contents_impl.h

diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h

index 8fc964948f17bbee00780ce4c76a848101cf36fd..ca667e47cf0774fcacb13fefac96955354f1870c 100644

--- a/content/browser/web_contents/web_contents_impl.h

+++ b/content/browser/web_contents/web_contents_impl.h

@@ -588,7 +588,8 @@ class CONTENT_EXPORT WebContentsImpl

override;

RenderWidgetHostInputEventRouter* GetInputEventRouter() override;

void ReplicatePageFocus(bool is_focused) override;

- RenderWidgetHostImpl* GetFocusedRenderWidgetHost() override;

+ RenderWidgetHostImpl* GetFocusedRenderWidgetHost(

+ RenderWidgetHostImpl* receiving_widget) override;

void RendererUnresponsive(RenderWidgetHostImpl* render_widget_host) override;

void RendererResponsive(RenderWidgetHostImpl* render_widget_host) override;

void RequestToLockMouse(RenderWidgetHostImpl* render_widget_host,

« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_mac.mm ('k') | content/browser/web_contents/web_contents_impl.cc » ('j') | no next file with comments »