Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Issue 1462973002: add SkRecordOptimize2 and an experimental API for more aggressive opts (Closed)

Created:
5 years, 1 month ago by reed1
Modified:
5 years, 1 month ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

add SkRecordOptimize2 and an experimental API for more aggressive opts BUG=skia: Committed: https://skia.googlesource.com/skia/+/f38b0d86b888692f7d703916114781be43249600

Patch Set 1 #

Total comments: 5

Patch Set 2 : #

Total comments: 2

Patch Set 3 : nasty manual rebase #

Patch Set 4 : fix bugs in manual merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -13 lines) Patch
M src/core/SkRecordOpts.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/core/SkRecordOpts.cpp View 1 2 3 3 chunks +64 lines, -13 lines 0 comments Download
M tools/dump_record.cpp View 1 2 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
reed1
WIP at the moment
5 years, 1 month ago (2015-11-19 16:14:15 UTC) #2
mtklein
https://codereview.chromium.org/1462973002/diff/1/src/core/SkRecordOpts.cpp File src/core/SkRecordOpts.cpp (right): https://codereview.chromium.org/1462973002/diff/1/src/core/SkRecordOpts.cpp#newcode40 src/core/SkRecordOpts.cpp:40: // TODO: tried Star<Or<Is<Noop>, Is<SetMatrix>>>, but it seemed to ...
5 years, 1 month ago (2015-11-19 16:26:56 UTC) #3
reed1
https://codereview.chromium.org/1462973002/diff/1/src/core/SkRecordOpts.cpp File src/core/SkRecordOpts.cpp (right): https://codereview.chromium.org/1462973002/diff/1/src/core/SkRecordOpts.cpp#newcode40 src/core/SkRecordOpts.cpp:40: // TODO: tried Star<Or<Is<Noop>, Is<SetMatrix>>>, but it seemed to ...
5 years, 1 month ago (2015-11-19 17:29:44 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1462973002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1462973002/20001
5 years, 1 month ago (2015-11-19 17:29:59 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/4074)
5 years, 1 month ago (2015-11-19 17:31:21 UTC) #8
mtklein
lgtm https://codereview.chromium.org/1462973002/diff/20001/src/core/SkRecordOpts.cpp File src/core/SkRecordOpts.cpp (right): https://codereview.chromium.org/1462973002/diff/20001/src/core/SkRecordOpts.cpp#newcode40 src/core/SkRecordOpts.cpp:40: typedef Pattern3<Is<SetMatrix>, Sorry, moved the goalposts. This is ...
5 years, 1 month ago (2015-11-19 17:39:22 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1462973002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1462973002/40001
5 years, 1 month ago (2015-11-19 18:08:44 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot/builds/4354)
5 years, 1 month ago (2015-11-19 18:09:34 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1462973002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1462973002/60001
5 years, 1 month ago (2015-11-19 18:18:51 UTC) #16
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 18:31:11 UTC) #17
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/f38b0d86b888692f7d703916114781be43249600

Powered by Google App Engine
This is Rietveld 408576698